Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Move blocks raw handling tests to test/integration folder #6731

Merged
merged 2 commits into from
May 14, 2018
Merged

Tests: Move blocks raw handling tests to test/integration folder #6731

merged 2 commits into from
May 14, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 14, 2018 •
edited
Loading

Description

Follow up for #6521. Related to #6730.

This PR moves all tests that depend on registered core block to the test/integration folder.

How has this been tested?

npm test

Types of changes

Refactoring.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@gziolo gziolo added [Feature] Blocks Overall functionality of blocks [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels May 14, 2018
@gziolo gziolo added this to the 2.9 milestone May 14, 2018
@gziolo gziolo self-assigned this May 14, 2018
@gziolo gziolo changed the title Tests: Move integration tests to core blocks module Tests: Move integration tests to test/integration folder May 14, 2018
@gziolo gziolo changed the title Tests: Move integration tests to test/integration folder Tests: Move blocks raw handling tests to test/integration folder May 14, 2018
@gziolo gziolo mentioned this pull request May 14, 2018
Closed
3 tasks
youknowriad
youknowriad approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me 👍

@gziolo gziolo merged commit 4bcbe3c into master May 14, 2018
@gziolo gziolo deleted the update/test-core-blocks-move branch May 14, 2018 09:46
@gziolo gziolo mentioned this pull request May 14, 2018
Merged
3 tasks
@ellatrix
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees

@gziolo gziolo

Labels
[Feature] Blocks Overall functionality of blocks [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
3 participants
@gziolo @ellatrix @youknowriad