Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Move applicable hooks from editor to blocks #6730

Closed
wants to merge 1 commit into from

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 14, 2018

Description

This PR reverts some of the changes introduced when moving blocks components to editor module with #6521. It turns out, that some of the hooks are related to the Blocks API. I moved all those hooks back. The next step (follow-up PR) is going to be to rename all hooks that are left in the editor module.

How has this been tested?

Manually checked that there are no regressions introduced.

npm test still passes.

Types of changes

Refactoring. Moved some code between folders.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@gziolo gziolo added the [Feature] Blocks Overall functionality of blocks label May 14, 2018
@gziolo gziolo added this to the 2.9 milestone May 14, 2018
@gziolo gziolo self-assigned this May 14, 2018
@gziolo gziolo requested review from youknowriad and a team May 14, 2018 07:45
@gziolo
Copy link
Member Author

gziolo commented May 14, 2018

I discussed this proposal with @youknowriad and we agreed that we shouldn't move those hooks back as they fit better editor module. Instead, I will make sure that all tests inside blocks module don't depend on the registered core blocks. #6731 moves out all tests that need to depend on core block. I will open a follow-up which updates all others tests later this week.

@gziolo gziolo closed this May 14, 2018
@gziolo gziolo deleted the update/move-blocks-hooks-back branch May 14, 2018 08:24
@gziolo gziolo removed this from the 2.9 milestone May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant