Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Remove obsolete Block Hooks filters [AFTER WP 6.7!] #64676

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Aug 21, 2024

Do not merge before Gutenberg's minimum required WordPress version is 6.6!

What?

Remove a number of Block Hooks related filters from the Navigation block.

Why?

As of WP 6.6, Core takes care of these things (by adding its own filters).

How?

By removing code.

Testing Instructions

This should be covered by unit tests (which are run both against the current and previous WP versions).
In addition, you can smoke-test Block Hooks in the Navigation block as described in other related PRs, e.g. #59021.

@ockham ockham added [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block [Feature] Block hooks labels Aug 21, 2024
@ockham ockham self-assigned this Aug 21, 2024
@ockham ockham changed the base branch from trunk to remove/now-obsolete-block-hooks-compat-checks August 21, 2024 09:13
Base automatically changed from remove/now-obsolete-block-hooks-compat-checks to trunk August 21, 2024 14:01
@ockham ockham force-pushed the remove/navigation-block-block-hooks-filters branch from 47d632c to d4a6878 Compare August 21, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Block hooks [Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant