Navigation Block: Remove now-obsolete function_exists guards #64673
+10
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
function_exists()
guards that checked for existence of theset_ignored_hooked_blocks_metadata
function.block_core_navigation_update_ignore_hooked_blocks_meta
function was attached to therest_insert_wp_navigation
action hook, and removed it if it was.Why?
The
set_ignored_hooked_blocks_metadata
function was introduced in WP 6.5, and Gutenberg now requires WP 6.5 as a minimum.Same for the
block_core_navigation_update_ignore_hooked_blocks_meta
action removal: This was only relevant for older GB versions and during some WP 6.5 Betas (see the original phrasing of the comment here); it is now obsolete.How?
By removing them 🤷♂️
Testing Instructions
This should be covered by unit tests (which are run both against the current and previous WP versions).
In addition, you can smoke-test Block Hooks in the Navigation block as described in other related PRs, e.g. #59021.
Follow-up
We'll be able to remove even more code once WP 6.7 is the minimum requirement for Gutenberg: #64676