Data Views: Add padding around selected values in author filter #63212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -7 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
akasunil
added
[Type] Enhancement
t-hamano
reviewed
Jul 7, 2024
There was a problem hiding this comment.
Thanks for the PR!
If we apply height:auto, the height will not be 32px when the text does not wrap.
I think the expected behavior here is:
- When the text doesn't wrap, the height is 32px
- When the text wraps, there is a small amount of padding above and below the chip
With this in mind, I think the following style would be appropriate:
.dataviews-filter-summary__chip {
padding: $grid-unit-05 $grid-unit-15;
min-height: $grid-unit-40;
}
t-hamano
approved these changes
Jul 8, 2024
|
This seems like a good interim step. We can continue to polish chips in #59696. |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
…Press#63212) * Add padding around selected value for filtering in dataview * Replace height with min-height for single author selection Co-authored-by: akasunil <sunil25393@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #63152
Why?
Missing space around selected values in dataview filter due to fixed height of 32px, This PR resolve that issue by setting auto height and adding top-bottom padding.
Screenshots or screencast