Disable the Preview button when post type isn't viewable

[danielbachhuber]

Description

In the classic editor, the preview button is only available if is_post_type_viewable returns true. We are updating the logic to follow the same behavior.

Fixes #5749

Previously #5770 #6120

How Has This Been Tested?

Register a post type with publicly_queryable set to false.
E.g:

function create_product_type() {
	register_post_type( 'acme_product',
		array(
			'label'  => 'Product',
			'labels' => array(
				'name' => __( 'Products' ),
				'singular_name' => __( 'Product' )
			),
			'public' => true,
			'show_in_rest' => true,
			'publicly_queryable' => false,
		)
	);
}
add_action( 'init', 'create_product_type' );

Verify preview button is not available for posts of this Post Type.

[danielbachhuber]

@pento There doesn't seem to be a good way to test a component using ifCondition. Specifically, I tried the following and didn't see what I expected:

it( 'should be null if the post type is not viewable', () => {
	const wrapper = shallow(
		<PostPreviewButton
			postId={ 1 }
			isSaveable
			isViewable={ false }
			link="https://wordpress.org/?p=1" />
	);
	expect( wrapper ).toBe( null );
} );

Is there a direction you can point me in, or should we punt on it for now?

[gziolo]

@danielbachhuber, given that isViewable is coming from REST API and is never used inside the component because HOC bails out early when it is set to false, it won't work this way. In general, we don't test all those HOCs with unit tests. You could do it, but it's usually too much work to mock all dependencies which only slows us down when doing refactoring later. See also this section in our testing docs: https://github.com/WordPress/gutenberg/blob/master/docs/testing-overview.md#pain-points.

[youknowriad]

LGTM 👍

[youknowriad]

Merged to include in the release.

[heldervilela]

Related to this topic.
In the WP 5.0 if the post type is 'publicly_queryable' => false the editor show the notice "Updating failed".

Because of this error:

Let me know if more info is needed.

[danielbachhuber]

@heldervilela Could you start a new issue for your bug, please? Having a new issue will help ensure the conversation isn't lost, and that your particular need is tracked through to resolution.