Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'View post' links shown when post type is not publicly_queryable #8151

Closed
jchristopher opened this issue Jul 23, 2018 · 7 comments
Closed

'View post' links shown when post type is not publicly_queryable #8151

jchristopher opened this issue Jul 23, 2018 · 7 comments
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jchristopher
Copy link

Describe the bug
When working with a post type that has publicly_queryable set to false links are shown to view the post on the front end, which leads to a 404

To Reproduce
Steps to reproduce the behavior:

  1. Register custom post type with 'publicly_queryable' => false
  2. Add new post for that post type

Expected behavior
No 'view' links shown

Screenshots
2018-07-23 at 4 58 pm

Desktop (please complete the following information):

  • OS: macOS High Sierra
  • Browser Firefox
  • 62.0b8

Additional context
Gutenberg version 3.3.0

@designsimply designsimply added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. labels Jul 24, 2018
@designsimply
Copy link
Member

👋😊 hi @jchristopher!

@Soean
Copy link
Member

Soean commented Jul 24, 2018

This was implemented for the preview button in #6232. We have to implement it for the other preview links in the editor as well.

@danielbachhuber danielbachhuber added Backwards Compatibility Issues or PRs that impact backwards compatability and removed Needs Testing Needs further testing to be confirmed. labels Jul 24, 2018
@danielbachhuber danielbachhuber self-assigned this Jul 24, 2018
@danielbachhuber danielbachhuber added the Needs Design Feedback Needs general design feedback. label Jul 26, 2018
@danielbachhuber danielbachhuber removed their assignment Jul 26, 2018
@danielbachhuber
Copy link
Member

Flagging this as Needs Design Feedback because it's more than just disabling the preview link:

image

We need some alternate UX for this:

image

@karmatosed
Copy link
Member

Just working through this, it seems if you can't preview then don't show the preview links. This would include showing 'no title' is live and 'view post'. Does that solve the issue?

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Oct 15, 2018
@danielbachhuber
Copy link
Member

danielbachhuber commented Oct 15, 2018

@karmatosed What should be shown instead? Can we get specific direction on how this should be implemented?

@karmatosed
Copy link
Member

karmatosed commented Oct 17, 2018

As discussed in core triage session, here is a mock of the button removal. It doesn't seem to make sense to both show link and buttons.

postpublished

@youknowriad
Copy link
Contributor

Fixed in #12046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants