Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Inserter: Fix browser warning error when opening custom pattern category #51870

Closed
wants to merge 2 commits into from
Closed

Block Inserter: Fix browser warning error when opening custom pattern category #51870

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4759652
Block Inserter: Fix browser warning error when opening custom pattern…
t-hamano Jun 25, 2023
25d6d8c
Try another approach
t-hamano Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/block-editor/src/components/block-patterns-list/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,11 @@ function BlockPatternList( {
className="block-editor-block-patterns-list"
aria-label={ label }
>
{ blockPatterns.map( ( pattern ) => {
{ blockPatterns.map( ( pattern, index ) => {
const isShown = shownPatterns.includes( pattern );
return isShown ? (
<BlockPattern
key={ pattern.name }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, I thought pattern names are meant to be unique?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why the pattern names are duplicated, but am I correct in assuming that the pattern name duplication itself should be corrected so that it does not happen?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should ensure that each pattern name gets a unique name otherwise we risk bigger issues (like when using patterns in themes where we only refer to them using the names).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to fix this with 25d6d8c, but this does not seem to be enough as the test fails. I would like to close this PR and submit an issue, as it seems to be too difficult for me to fix this now 😅

Copy link
Contributor

@glendaviesnz glendaviesnz Jun 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These patterns are the new unsynced wp_block CPT patterns added by users so all have the name core/block instead of the unique slug names of other patterns. As with the existing reusable blocks they don't need to have a unique name as they are identified by the entity id.

I have added a PR here that should resolve this.

key={ index }
pattern={ pattern }
onClick={ onClickPattern }
onHover={ onHover }
Expand All @@ -146,7 +146,7 @@ function BlockPatternList( {
showTooltip={ showTitlesAsTooltip }
/>
) : (
<BlockPatternPlaceholder key={ pattern.name } />
<BlockPatternPlaceholder key={ index } />
);
} ) }
</Composite>
Expand Down
Loading