Block Inserter: Fix browser warning error when opening custom pattern category #51870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
fix/non-synced-pattern-inserter-error
branch
from
c6cc68a
to
4759652
Compare
t-hamano
changed the title
t-hamano
added
[Feature] Inserter
youknowriad
reviewed
Jun 25, 2023
| const isShown = shownPatterns.includes( pattern ); | ||
| return isShown ? ( | ||
| <BlockPattern | ||
| key={ pattern.name } |
There was a problem hiding this comment.
I don't understand, I thought pattern names are meant to be unique?
There was a problem hiding this comment.
I don't know why the pattern names are duplicated, but am I correct in assuming that the pattern name duplication itself should be corrected so that it does not happen?
There was a problem hiding this comment.
Yes, I think we should ensure that each pattern name gets a unique name otherwise we risk bigger issues (like when using patterns in themes where we only refer to them using the names).
There was a problem hiding this comment.
I have tried to fix this with 25d6d8c, but this does not seem to be enough as the test fails. I would like to close this PR and submit an issue, as it seems to be too difficult for me to fix this now 😅
There was a problem hiding this comment.
These patterns are the new unsynced wp_block CPT patterns added by users so all have the name core/block instead of the unique slug names of other patterns. As with the existing reusable blocks they don't need to have a unique name as they are identified by the entity id.
I have added a PR here that should resolve this.
|
Size Change: +885 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a browser warning error that is output when opening a custom pattern category from the main block inserter.
Why?
This is because the
pattern.nameof the custom pattern iscore/blockand thekeyis duplicated in themapfunction.How?
Replaced with
index.Testing Instructions