Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datepicker styling to inherit font-family/colour scheme #4814

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

paulwilde
Copy link
Contributor

@paulwilde paulwilde commented Feb 1, 2018

Updates the datepicker style so its more consistent with the overall Gutenberg UI.

datepickers

@youknowriad youknowriad added the Needs Design Feedback Needs general design feedback. label Feb 2, 2018
@jasmussen
Copy link
Contributor

This seems a vast improvement over what was there before. That's a lot of variables and CSS to override the datepicker, though — are there any bundled style we could unload so we don't have to override? Or is this the simplest it gets?

Either way, 👍 👍 visually, nice work 🏅

@paulwilde
Copy link
Contributor Author

@jasmussen I honestly don't think there's much else that can be done to slim it down rather than manually styling the datepicker and ignoring the import all together.

The CSS which is being imported is around 500 lines long, so it's not that huge to be honest.

@jasmussen
Copy link
Contributor

Then no objections and thanks for the contribution!

@aduth
Copy link
Member

aduth commented Feb 8, 2018

Related: #1311 (uncertain future for this component's inclusion)

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Mar 7, 2018
@karmatosed
Copy link
Member

Let's get this in as we haven't a decision unless I'm missing it, on replacing. It feels a solid fix to get in today. Thanks.

@karmatosed karmatosed merged commit 6727993 into WordPress:master Mar 7, 2018
@mtias
Copy link
Member

mtias commented Mar 7, 2018

Thanks @paulwilde, this is great. When/if we replace the base component we'll just replicate the styling.

@paulwilde paulwilde deleted the update/datepicker-styles branch March 7, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants