Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: fix image resizing handles in RTL mode #3909

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

yoavf
Copy link
Contributor

@yoavf yoavf commented Dec 11, 2017

Description

Prevent the handle positions in the CSS from being flipped in RTL mode.
This is necessary after #3844 since the position of the handles is handled in JS.

Screenshots (jpeg or gifs if applicable):

Before:
screen shot 2017-12-11 at 16 06 59

After:
screen shot 2017-12-11 at 16 18 15

Types of changes

CSS change to prevent automatic flipping of CSS properties.
The ! before the rtlcss directive is necessary since the positions are set in the css with !important. Actually, because of scss.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@mtias
Copy link
Member

mtias commented Dec 11, 2017

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants