chore: Address comments in #3911 #7690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntwb
approved these changes
Jul 3, 2018
|
All that work to do this and then I merged the old PR absentmindedly. sigh 😔 |
tofumatt
force-pushed
the
yoavf-update/blocks-alignment-rtl
branch
from
f4d1e44
to
2d59a39
Compare
tofumatt
force-pushed
the
yoavf-update/blocks-alignment-rtl
branch
from
2d59a39
to
fa59f48
Compare
tofumatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just #3911 but with comments fixed. #3911 is approved but I couldn't push comments tweaks to it so it's here. 🤷♂️
Description
I merged #3911 but these are comment tweaks I requested in that PR.