Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror WordPress plugin install text for blocks #25084

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Mirror WordPress plugin install text for blocks #25084

merged 1 commit into from
Sep 10, 2020

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Sep 4, 2020

Description

Related to #24842 —I've modified the text to mirror the implementation of the plugin installations count text from WordPress.

Something to consider is that number_format_i18n is not implemented yet for Gutenberg.(#22628)

How has this been tested?

Added tests for each variation.

Screenshots

image

image

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ryelle ryelle added the [Feature] Block Directory Related to the Block Directory, a repository of block plugins label Sep 4, 2020
@ryelle ryelle self-requested a review September 4, 2020 22:42
@vcanales
Copy link
Member Author

vcanales commented Sep 9, 2020

Hi @ryelle ! Have you had a chance to look at this? I'd appreciate your input :)

Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! and thanks for the tests, since there are no blocks yet with over a million installations 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants