Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"0 active installations" should say "Less than 10 active installations" #24842

Closed
dd32 opened this issue Aug 27, 2020 · 2 comments
Closed

"0 active installations" should say "Less than 10 active installations" #24842

dd32 opened this issue Aug 27, 2020 · 2 comments
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@dd32
Copy link
Member

dd32 commented Aug 27, 2020

Describe the bug
Currently the Block Installer only has a plural %s active installation(s) where as WordPress has 3 distinct states for plugins:

  • 0 = Fewer than 10
  • over 10 = %s active installation(s)
  • over 1 million = %d+ million active installation(s)

{ sprintf(
/* translators: %s: number of active installations. */
_n(
'%d active installation',
'%d active installations',
activeInstalls
),
activeInstalls
) }

Note: WordPress.org says "Fewer than" rather than "Less than".

To reproduce
Steps to reproduce the behavior:

  1. Search for a block that's brand new and installed nowhere (or on less than 10 sites).
  2. Admire "0 active installations"

Expected behavior
It should state something like "Less than 10 active installations"

Screenshots
searchResults
(Uh, the Emoji's work normally.. just don't work in the browser that screenshot came from..)

Editor version (please complete the following information):

  • WordPress version: 5.5
  • Does the website has Gutenberg plugin installed, or is it using the block editor that comes by default? default
@dd32 dd32 added the [Feature] Block Directory Related to the Block Directory, a repository of block plugins label Aug 27, 2020
@mtias mtias added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Aug 28, 2020
@kartecianos
Copy link

kartecianos commented Sep 8, 2020

Hi I would like to work on this issue, is it still open?

I saw vcanales pull request but it seems to have a problem with values 1-9 because it seems that it should be printed 'Fewer than 10' instead of just the number of active installs.

@ryelle
Copy link
Contributor

ryelle commented Sep 22, 2020

This is fixed with #25084

@kartecianos The API rounds to 10, so it should never return 1-9. Are you seeing any block plugins that return a value in 1-9?

@ryelle ryelle closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

4 participants