Try: Show metaboxes peeking in even on tiny screens. #20262
Conversation
| @@ -27,7 +27,7 @@ | |||
|
|
|||
| .edit-post-visual-editor .block-editor-writing-flow__click-redirect { | |||
| // Allow the page to be scrolled with the last block in the middle. | |||
There was a problem hiding this comment.
Just wanted to document with a screenshot, that this is still the case:
jorgefilipecosta
dismissed
their stale review
we should fix end to end tests before merging
|
Thanks, that would explain why the tests keep failing. It looks like this test is failling: I don't understand why that would fail based on this change. I tried more or less manually repeating the test and I see no scrolling happening. How small is the viewport supposed to be? |
|
I noticed that there's a gray background around metaboxes, I'm pretty sure that's unintended and probably a result of the "preview devices". That said, preview devices is not on 5.4 so it's better to address in a separate PR that is not cherry-picked. |
| @@ -27,7 +27,7 @@ | |||
|
|
|||
| .edit-post-visual-editor .block-editor-writing-flow__click-redirect { | |||
| // Allow the page to be scrolled with the last block in the middle. | |||
| min-height: 50vh; | |||
| min-height: 40vh; | |||
There was a problem hiding this comment.
This feels like a random number used to give some space for meta boxes. I'm not sure if we can do better though.
There was a problem hiding this comment.
We can, but not without a biggish refactor of the component. There's an argument that it was a bit random before as well — 50vh is half of the entire viewport. But it should have been half of the viewport, minus header, footer and optionally the adminbar if not fullscreen, with extra rules for mobile contexts.
youknowriad
force-pushed
the
try/metabox-fold
branch
from
92086b6
to
92e94e7
Compare
jasmussen
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
I'm not exactly sure why the test was failing (locally it passes). I'm trying a "guess-fix" in the last commit. Let's see how it goes. |
|
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
|
In the past, some very viewport dimension sensitive tests failed due to things like text wrapping in the test VM, but not when we test it manually. That could come down to something as simple as the Linux VM running a different/larger font than us Mac users. |
|
Tests pass! Thumbs up? |
|
Go |
|
:D I need an approval! |
youknowriad
added
Backport to WP 6.7 Beta/RC
* Try: Show metaboxes peeking in even on tiny screens. Fixes #19709. * Try fixing the e2e test Co-authored-by: Riad Benguella <benguella@gmail.com>
* Try: Show metaboxes peeking in even on tiny screens. Fixes #19709. * Try fixing the e2e test Co-authored-by: Riad Benguella <benguella@gmail.com>
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Fixes #19709.
19709 reports that if metaboxes are present on the page, on a new page they might be out of sight below the fold and therefore hard to find.
The CSS to enable the editor to scale as it does is rather complicated and could use a greater refactor. For example, the div that is dedicated to
editor-styles-wrapperis currently born with a hard coded top padding, which seems like something the theme should provide. Combine that with various flex rules, and there's an opportunity to make strides here.But the canvas is currently in the midst of a great deal of open heart surgery with DOM nodes being removed left and right, and lots of other block paddings being revisited in #18667 it really doesn't feel like the right time to rearrange those bits.
In that vein, this PR does the smallest possible thing it can to fix the issue, which is to simply reduce the min-height of the click redirect.
If you make the viewport less tall than this, the left navigation sidebar will start to scroll.