Try: Show metaboxes peeking in even on tiny screens. (#20262)

* Try: Show metaboxes peeking in even on tiny screens. Fixes #19709. * Try fixing the e2e test Co-authored-by: Riad Benguella <benguella@gmail.com>
WordPress · Feb 24, 2020 · 557c7cf · 557c7cf
1 parent cadfb1b
commit 557c7cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/e2e-tests/specs/editor/various/navigable-toolbar.test.js b/packages/e2e-tests/specs/editor/various/navigable-toolbar.test.js
@@ -50,11 +50,12 @@ describe.each( [
 	if ( ! isUnifiedToolbar ) {
 		it( 'should not scroll page', async () => {
 			while (
-				await page.evaluate(
-					() =>
-						wp.dom.getScrollContainer( document.activeElement )
-							.scrollTop === 0
-				)
+				await page.evaluate( () => {
+					const scrollable = wp.dom.getScrollContainer(
+						document.activeElement
+					);
+					return ! scrollable || scrollable.scrollTop === 0;
+				} )
 			) {
 				await page.keyboard.press( 'Enter' );
 			}

diff --git a/packages/edit-post/src/components/visual-editor/style.scss b/packages/edit-post/src/components/visual-editor/style.scss
@@ -25,7 +25,7 @@
 
 .edit-post-visual-editor .block-editor-writing-flow__click-redirect {
 	// Allow the page to be scrolled with the last block in the middle.
-	min-height: 50vh;
+	min-height: 40vh;
 	width: 100%;
 }