-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Show metaboxes peeking in even on tiny screens. #20262
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ | |
|
||
.edit-post-visual-editor .block-editor-writing-flow__click-redirect { | ||
// Allow the page to be scrolled with the last block in the middle. | ||
min-height: 50vh; | ||
min-height: 40vh; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This feels like a random number used to give some space for meta boxes. I'm not sure if we can do better though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can, but not without a biggish refactor of the component. There's an argument that it was a bit random before as well — 50vh is half of the entire viewport. But it should have been half of the viewport, minus header, footer and optionally the adminbar if not fullscreen, with extra rules for mobile contexts. |
||
width: 100%; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to document with a screenshot, that this is still the case: