Fix: Image resizer does not work if only one dimension is changed #16398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
ajitbohra,
gziolo,
Soean,
talldan and
youknowriad
as code owners
youknowriad
reviewed
Jul 4, 2019
jorgefilipecosta
deleted the
fix/image-resizing-does-not-work-if-only-one-dimension-is-changed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #12278
Image sizes were only applied to the editor if both width and height were set. This PR applies the sizes even if just one of the dimensions is set.
How has this been tested?
I added an image, I went to the image dimensions setting, I changed the width by writing a new number. I verified the new dimension was applied. On master, nothing happens until the height is also set, but the attribute is changed anyway and when we view the post on the frontend the dimension is applied.