Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel-sizing only works after setting image size percentage #12278

Closed
mrwweb opened this issue Nov 24, 2018 · 0 comments · Fixed by #16398
Closed

Pixel-sizing only works after setting image size percentage #12278

mrwweb opened this issue Nov 24, 2018 · 0 comments · Fixed by #16398
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@mrwweb
Copy link

mrwweb commented Nov 24, 2018

Describe the bug
This is related to #12276, #12277, and #12168 in various ways.

When inserting an image in 5.0-RC1, the pixel sizer doesn't work unless a percentage is set first.

The pixel sizer jumps from it's initial value to 1 the when hitting up (i.e. it's as if the value is 0 and 1 is added) and the size in pixels is not set either.

It appears that the sizing kicks in once both dimensions are set. As I tested this, I think I realized that the pixel dimension fields aren't actually set with values but instead have placeholders. I suspect that's the root cause of the issue. (Placeholders are always confusing!)

To Reproduce

  1. Insert an image
  2. Hit the "Up" control on the number field of either the width or height pixel size settings fields

Expected behavior
Image is proportionally scaled by 1px in that dimension. If the image is 300px wide, the image is now 301px wide.

Screenshots
image-pixel-sizing-bug

Desktop (please complete the following information):
Win 10, Firefox 63.0.3, WP 5.0-RC1, no plugins, Twenty Nineteen

@afercia afercia added the [Type] Bug An existing feature does not function as intended label Nov 24, 2018
@designsimply designsimply added the [Block] Image Affects the Image Block label Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants