Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate gutenberg_add_gutenberg_post_state #13471

Merged
merged 2 commits into from
Jan 28, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 24, 2019

Related: #11015

This pull request seeks to deprecate and remove logic from gutenberg_add_gutenberg_post_state . This added the "Gutenberg" text on a post in the post listing screen.

image

With 5.0 being released, this no longer really serves a purpose to distinguish posts.

Testing instructions:

Verify there is no "Gutenberg" label on posts in the post listing screen.

@aduth aduth added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jan 24, 2019
@aduth aduth force-pushed the remove/gutenberg-post-state branch from 3b8f5e8 to 1556bf2 Compare January 24, 2019 14:43
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The editor continues to work as before, the warning related to the containing Gutenberg blocks still appear if we try to open the post in the classic editor. I did not found any other usage of gutenberg_add_gutenberg_post_state.

@aduth
Copy link
Member Author

aduth commented Jan 28, 2019

the warning related to the containing Gutenberg blocks still appear if we try to open the post in the classic editor.

For what it's worth, this will separately be removed as of #13442 . Kinda curious how you were able to load the classic editor in the first place 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants