Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Remove redundant core compatibility from plugin #13442

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 23, 2019

Related: #11015

This pull request seeks to remove (deprecated) logic in lib/compat.php assumed to be present in core.

The primary core tracking issue is:

The only remaining compatibility is that of gutenberg_show_privacy_policy_help_text. I could not find an equivalent core compatibility. The one here assumes wrongly that Gutenberg will upgrade the notices, which was removed as part of #12444 . This requires more work. In the meantime, the code in lib/compat.php has been left as-is.

Testing instructions:

Verify there are no regressions in the loading of the editor.

@aduth aduth added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jan 23, 2019
@aduth aduth added Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code and removed Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels Jan 23, 2019
@aduth
Copy link
Member Author

aduth commented Jan 25, 2019

The only remaining compatibility is that of gutenberg_show_privacy_policy_help_text. I could not find an equivalent core compatibility. The one here assumes wrongly that Gutenberg will upgrade the notices, which was removed as part of #12444 . This requires more work. In the meantime, the code in lib/compat.php has been left as-is.

In doing some further investigation and in discussing with @desrosj , it's true that this compatibility does not exist. However, the logic lingering here in lib/compat.php does nothing to help, and thus I'm inclined to defer to a core revision to reimplement the notice for the block editor.

To this end, I've created a Trac ticket: https://core.trac.wordpress.org/ticket/46098

As such, I'll plan to include here a deprecation of gutenberg_show_privacy_policy_help_text.

@aduth aduth force-pushed the remove/compat-php branch 2 times, most recently from 3d84d7b to f36ec3e Compare January 26, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants