Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cloudflare warning #11350

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Remove Cloudflare warning #11350

merged 2 commits into from
Nov 1, 2018

Conversation

pento
Copy link
Member

@pento pento commented Nov 1, 2018

Description

We haven't seen reports of Cloudflare blocking REST API requests for a while, they've presumably done some tweaking to how their WAF behaves.

This PR removes the Cloudflare warning added in #8640.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@pento pento added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Nov 1, 2018
@pento pento added this to the 4.3 milestone Nov 1, 2018
@pento pento requested a review from a team November 1, 2018 05:53
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure anyone will know what those changelog messages are, so it’s best to remove them I think.

Side-note: I thought Gutenberg meant to move all its PHP to core? Is this file sticking around?

Otherwise looks good.

@@ -1,3 +1,9 @@
## 2.2.2 (Unreleased)

### Double You Tee Eff, Mate?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, wut?

Copy link
Member Author

@pento pento Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, I'm not that young! But just didn't know what it had to do with a changelog 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this stage in the project, classic memes are the only way to communicate. 😉

@pento
Copy link
Member Author

pento commented Nov 1, 2018

Okay, changelog entries are gone. 🙂

PHP files have all been merged to core, but this warning wasn't: it needed to be removed from the JS, so I've removed it from the PHP for completeness.

Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

more-red-than-green

@pento pento merged commit 20c7215 into master Nov 1, 2018
@pento pento deleted the chore/remove-cloudflare-warnings branch November 1, 2018 12:52
daniloercoli added a commit that referenced this pull request Nov 1, 2018
…rnmobile/port-quote-block-step-1

* 'master' of https://github.com/WordPress/gutenberg: (22 commits)
  Add removed periods to block descriptions. (#11367)
  Remove findDOMNode usage from the inserter (#11363)
  Remove deprecated componentWillReceiveProps from TinyMCE component (#11368)
  Create file blocks when dropping multiple files at once (#11297)
  Try avoiding the deprecated findDOMNode API from DropZone Provider (#11168)
  Fix: make meta+A behaviour of selecting all blocks work on safari and firefox. (#8180)
  Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets (#11342)
  Remove the Cloudflare warning (#11350)
  Image Block: Use source_url for media file link (#11254)
  Enhance styling of nextpage block using the Hr element (#11354)
  Embed block refactor and tidy (#10958)
  Nonce Middleware: Wrap the nonce middleware function into it's own function that isn't regenerated on every API request. (#11347)
  Fix RTL block alignments (#11293)
  RichText: fix buggy enter/delete behaviour (#11287)
  Remove code coverage setup (#11198)
  Parser: Runs all parser implementations against the same tests (#11320)
  Stop trying to autosave when title and classic block content both are empty. (#10404)
  Fix "Mac OS" typo + use fancy quotes consistently (#11310)
  Update documentation link paths (#11324)
  Editor: Reshape blocks state under own key (#11315)
  ...

# Conflicts:
#	gutenberg-mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants