Remove code coverage setup #11198
Remove code coverage setup #11198
Conversation
youknowriad
added
the
[Type] Build Tooling
package.json
Outdated
| @@ -152,7 +151,7 @@ | |||
| "check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2\" \"wp-scripts check-licenses --dev\"", | |||
| "precheck-local-changes": "npm run docs:build", | |||
| "check-local-changes": "( git diff -U0 | xargs -0 node bin/process-git-diff ) || ( echo \"There are local uncommitted changes after one or both of 'npm install' or 'npm run docs:build'!\" && exit 1 );", | |||
| "ci": "concurrently \"npm run lint\" \"npm run test-unit:coverage-ci\" \"npm run check-local-changes\"", | |||
| "ci": "concurrently \"npm run lint\" \"npm run check-local-changes\"", | |||
There was a problem hiding this comment.
test-unit:coverage-ci should still be here we just need to update it as follows:
"test-unit:coverage-ci": "npm run test-unit -- --ci --runInBand",
|
@gziolo My opinion is that it useless and just complexify the setup of the repository for nothing. Its results are not reliable and keeping it in the repository while not running in CI will more likely end up unmaintained. |
|
I don't plan to fight for keeping this functionality. If more people find is useless we can remove it. However |
|
I'd rather we not commit to maintaining it. It's likely to become neglected anyways if not part of the main pipeline. |
| @@ -24,8 +24,6 @@ npm install @wordpress/jest-preset-default --save-dev | |||
|
|
|||
| #### Brief explanations of options included | |||
|
|
|||
| * `coverageDirectory` - the directory where Jest outputs its coverage files is set to `coverage`. | |||
There was a problem hiding this comment.
We need to update changelog as this looks as a breaking change, or we can keep it as is 😄
I'm aware that probably nobody is using it.
|
LGTM, let's proceed when Travis is green. |
|
Cleaned up the merge conflict and the tests are now passing. I can update the changelog as well if you feel it should be, @youknowriad. I was going to make the change as a suggestion on the PR, but I wasn't sure which changelog to update (the package's vs. the global one), and which version to list the change in, though. I am assuming the package version, but not sure. |
|
Thanks for your help @desrosj we should update the package CHANGELOG, I'm going to do it right now. |
|
This should be ready to go I need a ✅ |
…rnmobile/port-quote-block-step-1 * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Add removed periods to block descriptions. (#11367) Remove findDOMNode usage from the inserter (#11363) Remove deprecated componentWillReceiveProps from TinyMCE component (#11368) Create file blocks when dropping multiple files at once (#11297) Try avoiding the deprecated findDOMNode API from DropZone Provider (#11168) Fix: make meta+A behaviour of selecting all blocks work on safari and firefox. (#8180) Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets (#11342) Remove the Cloudflare warning (#11350) Image Block: Use source_url for media file link (#11254) Enhance styling of nextpage block using the Hr element (#11354) Embed block refactor and tidy (#10958) Nonce Middleware: Wrap the nonce middleware function into it's own function that isn't regenerated on every API request. (#11347) Fix RTL block alignments (#11293) RichText: fix buggy enter/delete behaviour (#11287) Remove code coverage setup (#11198) Parser: Runs all parser implementations against the same tests (#11320) Stop trying to autosave when title and classic block content both are empty. (#10404) Fix "Mac OS" typo + use fancy quotes consistently (#11310) Update documentation link paths (#11324) Editor: Reshape blocks state under own key (#11315) ... # Conflicts: # gutenberg-mobile
The Code Coverage was helpful at the early stages of the project where we didn't have tests. It's not anymore as it only counts JavaScript unit tests and we have more tests than that. The results in PR are also not reliable. So let's just remove it to have a lighter setup.