-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem with zip file creation on Windows #606
Conversation
Just a thought. The plugin code doesn't use the path_join function at the moment. Syntax such as For consistency, would it be better to continue to use the |
We're introducing it as a part of another PR as well #601. There are also places where it might not be suitable to use it ie. where I don't see a drawback in introducing it here, and also gradually whenever we need to make changes to path handling logic. |
Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
Makes sense. Many thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took longer to get my windows environment working again then it did to test it (and for just a 2 line change at that 🤣 )
Works as expected. The unpacked zip archive looks as expected.
Thanks for this fix.
Fixes #602
This PR fixes an issue where files are not created correctly when using certain file archivers on Windows OS.
Where the problem occurs, the file is generated by
ZipArchive::addFromString
. The PHP documentation mentions the following:I don't know the exact cause, but I think backslashes are causing problems with certain file archivers.
Testing Instructions
Screenshot