Fix custom fonts assets path #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't been able to reproduce the issue; how do you suggest looking at the zip file in order to verify that it's including extra empty directories? |
vcanales
reviewed
Apr 28, 2024
@vcanales, here is a screencast showing the problem: Screencast.from.30-04-24.12.54.43.webm |
Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
…eate-block-theme into fix/custom-font-assets-path
pbking
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the custom fonts assets path in the exported zip.
Fixes: #600
How?
The two extra slashes from the path were removed. This removed the two empty folders being added to the zip file.
Testing instructions:
See #600