-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom fonts assets path #601
Conversation
I haven't been able to reproduce the issue; how do you suggest looking at the zip file in order to verify that it's including extra empty directories? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again. I think it doesn't hurt to guard against extra slashes, even if I can't figure out how to reproduce the exact issue. LGTM, pending considering the suggestion here
@vcanales, here is a screencast showing the problem: Screencast.from.30-04-24.12.54.43.webm |
Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
…eate-block-theme into fix/custom-font-assets-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Cleans up the code.
🚢
What?
Fix the custom fonts assets path in the exported zip.
Fixes: #600
How?
The two extra slashes from the path were removed. This removed the two empty folders being added to the zip file.
Testing instructions:
See #600