-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix changelog creation script #541
Conversation
The directory changes follows the guidelines in the docs: https://developer.wordpress.org/plugins/wordpress-org/plugin-developer-faq/#where-do-i-put-my-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this! It tests well for me. Running RELEASE_TYPE=major npm run update-version
, I see the commits from this branch, formatted as expected:
![image](https://private-user-images.githubusercontent.com/1645628/320124213-b9294a1c-d49b-4297-a022-4de9bd017874.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxMzMzMTksIm5iZiI6MTcyNDEzMzAxOSwicGF0aCI6Ii8xNjQ1NjI4LzMyMDEyNDIxMy1iOTI5NGExYy1kNDliLTQyOTctYTAyMi00ZGU5YmQwMTc4NzQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjBUMDU1MDE5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTZiOGE2NDgzYjg5Njg3YzVlOTI0ZTFiYTRkNTRjOGE3NmM0Zjc0NGZjY2ZkM2JjNTdlYWZiZTIyNzU5N2ZmNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.8lEYcv9559W3cMOiBaeq5J5p9yCKf_PKdA4Kvz6IdCI)
(The screenshot cuts off the bottom, the last line is "* Add text domain to translation target (#499)".)
I see the screenshot changes are in line with what's described in the plugin docs here, so these look fine too.
I think this is good to bring in 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also working well for me! I tested the update-version
command with major and minor versions.
One question, why change screenshots from jpg to png? The png file size is a lot larger.
No particular reason, that's just the default for when I took them. I've transformed them to jpeg on ef6add0; thanks for spotting! |
Previous Changelogs have come up empty; this PR ensures that the changes since the last tag created are correctly added to the Changelog.
--merge
, since we're not using merge commits.message
instead of the body; GitHub automatically sets the squashed commit to the PR title and adds the number. This should always be available, but will still addbody
as a fallback just in case something is committed without a PR.git
itself to determine the last tag created, instead of using the package.json file.Sample output for v2.0.0 from the updated script:
Testing:
Run
RELEASE_TYPE=major npm run update-version
— Your changelog file will include the commits from this branch, which is fine; when merged, it'll only use the history fromtrunk
.