-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text domain to translation target #499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! @Olein-jp, thanks for submitting this PR.
It seems like the translation domain for the string you updated is already there, and the PR is only changing whitespaces, or I'm missing something else?
Plugin Description`, 'create-block-theme' ) } | ||
Plugin Description`, | ||
'create-block-theme' | ||
) } | ||
value={ theme.recommended_plugins } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the translation domain (create-block-theme
) is already there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added text domain here, but it gave me a JS syntax error, so I adjusted the whitespace separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks like the text domain was missing from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @Olein-jp! Looks good to me, and I can't see any other missing text domains in any other __()
calls.
When I was using the plugin in a Japanese environment, I found a few points that were translated but not adapted.
After checking the source code, I found that the text domain was not described in the corresponding sections, so I added them.
I also found a few other cases, so we took the same measures.