-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace font management with screen pointing to native font library #539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tinkered a bit with the copy, and made it translatable. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too! Great, simple design 👏
I don't think we have a better link than the 6.5 release post, we can always update this later if needed.
If I understand correctly, this looks like a breaking change.
|
I consider this a "breaking change" in that the functionality to manage fonts is now done differently. (Which is why we are releasing it with a major version change.) However, any theme previously managed fonts with CBT (or any other method) is completely compatible with this change and can continue to be managed with CBT.
Yes. If a user installed fonts via CBT 1.x then those assets are included in the theme and configured via
Yes, any font that is deactivated via the Font Library UI will be removed from the theme when the theme is saved via CBT. (See instructions on this issue where the functionality was migrated).
To clarify CBT installs fonts in a theme (copies the assets to the appropriate folder and includes the configuration to use those assets in |
I will add that additional instructions and documentation as to how to achieve all of the above is very necessary! |
@pbking Thank you for letting me know in detail. I didn't know that there was already an implementation for backward compatibility. If CBT's font management was fully compatible with the native font library, I think it would be perfectly fine. |
This change replaces the font management screen with links pointing to native font library.
This is an immediate change for 2.0
Clean up of the font management code is being done in #528