-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CORE for Font Management #518
Conversation
Adding this because tests in this PR depend on a function — wp_get_font_dir — that was introduced in 6.5
It isn't really working anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me. LGTM.
@@ -81,5 +81,5 @@ jobs: | |||
- name: Run PHP tests | |||
run: | | |||
mysql -uroot -h127.0.0.1 -e 'SELECT version()' \ | |||
&& ./bin/install-wp-tests.sh --recreate-db wordpress_test root '' > /dev/null \ | |||
&& ./bin/install-wp-tests.sh --wp-version=trunk --recreate-db wordpress_test root '' > /dev/null \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that it didn't work on nightly
; it worked here 420ad20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Very strange! I didn't expect it to, I just noticed the || in the code and gave it a whirl.
It made zero sense but I ran with it!
Fixes: #451
Copy ACTIVATED USER FONTS to the THEME when SAVED.
REMOVE UNACTIVATED FONTS from the THEME when SAVED.
To test:
Install Fonts to Theme
/assets/fonts
) and added to the theme.jsonUninstall Fonts from Theme