Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: Add a link to the "Find" view in the search popup #1665

Merged
merged 3 commits into from
May 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/de_DE.json
Original file line number Diff line number Diff line change
Expand Up @@ -799,6 +799,7 @@
"hex.builtin.view.hex_editor.search.find": "Suchen",
"hex.builtin.view.hex_editor.search.hex": "Hex",
"hex.builtin.view.hex_editor.search.no_more_results": "Keine weiteren Ergebnisse",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "String",
"hex.builtin.view.hex_editor.search.string.encoding": "Kodierung",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",
Expand Down
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/en_US.json
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,7 @@
"hex.builtin.view.hex_editor.search.string.endianness.little": "Little",
"hex.builtin.view.hex_editor.search.string.endianness.big": "Big",
"hex.builtin.view.hex_editor.search.no_more_results": "No more results",
"hex.builtin.view.hex_editor.search.advanced": "Advanced Search...",
"hex.builtin.view.hex_editor.select.offset.begin": "Begin",
"hex.builtin.view.hex_editor.select.offset.end": "End",
"hex.builtin.view.hex_editor.select.offset.region": "Region",
Expand Down
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/es_ES.json
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "Buscar",
"hex.builtin.view.hex_editor.search.hex": "Hexadecimal",
"hex.builtin.view.hex_editor.search.no_more_results": "No se encontraron más resultados",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "Cadena",
"hex.builtin.view.hex_editor.search.string.encoding": "Codificación",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",
Expand Down
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/it_IT.json
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "Cerca",
"hex.builtin.view.hex_editor.search.hex": "Hex",
"hex.builtin.view.hex_editor.search.no_more_results": "Nessun risultato trovato",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "Stringa",
"hex.builtin.view.hex_editor.search.string.encoding": "Codifica",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",
Expand Down
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/ja_JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "検索",
"hex.builtin.view.hex_editor.search.hex": "16進数",
"hex.builtin.view.hex_editor.search.no_more_results": "結果がありません",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "文字列",
"hex.builtin.view.hex_editor.search.string.encoding": "エンコード",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",
Expand Down
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/ko_KR.json
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "찾기",
"hex.builtin.view.hex_editor.search.hex": "헥스",
"hex.builtin.view.hex_editor.search.no_more_results": "더이상 결과 없음",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "문자열",
"hex.builtin.view.hex_editor.search.string.encoding": "エンコード",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",
Expand Down
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/pt_BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "Buscar",
"hex.builtin.view.hex_editor.search.hex": "Hex",
"hex.builtin.view.hex_editor.search.no_more_results": "Não há mais resultados",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "String",
"hex.builtin.view.hex_editor.search.string.encoding": "Codificação",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",
Expand Down
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/zh_CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,7 @@
"hex.builtin.view.hex_editor.search.find": "查找",
"hex.builtin.view.hex_editor.search.hex": "Hex",
"hex.builtin.view.hex_editor.search.no_more_results": "没有更多结果",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "字符串",
"hex.builtin.view.hex_editor.search.string.encoding": "编码",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",
Expand Down
1 change: 1 addition & 0 deletions plugins/builtin/romfs/lang/zh_TW.json
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,7 @@
"hex.builtin.view.hex_editor.search.find": "尋找",
"hex.builtin.view.hex_editor.search.hex": "十六進位",
"hex.builtin.view.hex_editor.search.no_more_results": "沒有更多結果",
"hex.builtin.view.hex_editor.search.advanced": "",
"hex.builtin.view.hex_editor.search.string": "字串",
"hex.builtin.view.hex_editor.search.string.encoding": "編碼",
"hex.builtin.view.hex_editor.search.string.encoding.utf16": "UTF-16",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ namespace hex::plugin::builtin {
ImGui::EndTabBar();
}

if(ImGuiExt::IconHyperlink(ICON_VS_SEARCH, "hex.builtin.view.hex_editor.search.advanced"_lang)) {
const auto& view = ContentRegistry::Views::getViewByName("hex.builtin.view.find.name");
view->getWindowOpenState() = true;
ImGui::SetWindowFocus(view->getName().c_str());
editor->closePopup();
}

if (lastMode != *s_searchMode) {
m_requestFocus = true;
s_inputString->clear();
Expand Down