impr: Add a link to the "Find" view in the search popup #1665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
This PR adds a shortcut link on the Search (Ctrl+F) popup to the more advanced "Find" view that is normally accessible at the
View > Find
menu.Implementation description
I added a simple
ImGuiExt::IconHyperlink
link to thedraw()
function of thePopupFind
class to display the hyperlink. Clicking the link will open the Find view, bring it into focus and close the current popup.Screenshots
Before:
![image](https://private-user-images.githubusercontent.com/45818400/329723077-0961f594-0548-426a-8622-20093d4a165e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwNDI3MDIsIm5iZiI6MTcyMTA0MjQwMiwicGF0aCI6Ii80NTgxODQwMC8zMjk3MjMwNzctMDk2MWY1OTQtMDU0OC00MjZhLTg2MjItMjAwOTNkNGExNjVlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE1VDExMjAwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdlYTVjM2VkZjQxMjkyMzMxMjliOTQ4M2QzOWIwZjVmM2MzMzMxYTdiOGRmYzE2ZGFhYTA1ZDQwYmU0ODhiMmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Qtam07CcW02R0TbR2nnopFzDVjk-LkdBuRfhtqG2QpM)
After:
![image](https://private-user-images.githubusercontent.com/45818400/329723207-d40d78f4-1a5d-4bf6-97a4-ff7ab40d0cef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEwNDI3MDIsIm5iZiI6MTcyMTA0MjQwMiwicGF0aCI6Ii80NTgxODQwMC8zMjk3MjMyMDctZDQwZDc4ZjQtMWE1ZC00YmY2LTk3YTQtZmY3YWI0MGQwY2VmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE1VDExMjAwMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc1NDk2Y2FkMTQzY2YxZGU4MWQzMjc1NmIyMTg2NjNlMTBiYzFjMGEwZDEyM2ViMTI3Y2E4MWQwNjlhNTA0ZmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YlNoKouR0bbfq4fINWpdbmDnIGeCAsFCY3HAVpn2lV8)
Additional things
en_US
is populated for now.