Convert all tool Popups to floating windows

lib/libimhex/include/hex/ui/imgui_imhex_extensions.h

@@ -161,6 +161,7 @@ namespace ImGuiExt {
 
         struct Styles {
             float WindowBlur = 0.0F;
+            float PopupWindowAlpha = 0.0F; // Alpha used by Popup tool windows when the user is not hovering over them
         } styles;
     };
 
@@ -304,6 +305,9 @@ namespace ImGuiExt {
     bool ToggleSwitch(const char *label, bool *v);
     bool ToggleSwitch(const char *label, bool v);
 
+    bool PopupTitleBarButton(const char* label, bool p_enabled);
+    void PopupTitleBarText(const char* text);
+
     template<typename T>
     constexpr ImGuiDataType getImGuiDataType() {
         if constexpr      (std::same_as<T, u8>)     return ImGuiDataType_U8;

lib/libimhex/source/ui/imgui_imhex_extensions.cpp

@@ -1235,6 +1235,59 @@ namespace ImGuiExt {
         return ToggleSwitch(label, &v);
     }
 
+    bool PopupTitleBarButton(const char* label, bool p_enabled)
+    {
+        ImGuiContext& g = *GImGui;
+        ImGuiWindow* window = g.CurrentWindow;
+        const ImGuiID id = window->GetID(label);
+        const ImRect title_rect = window->TitleBarRect();
+        const ImVec2 size(g.FontSize, g.FontSize); // Button size matches font size for aesthetic consistency.
+        const ImVec2 pos = window->DC.CursorPos;
+        const ImVec2 max_pos = pos + size;
+        const ImRect bb(pos.x, title_rect.Min.y, max_pos.x, title_rect.Max.y);
+
+        ImGui::PushClipRect(title_rect.Min, title_rect.Max, false);
+
+        // Check for item addition (similar to how clipping is handled in the original button functions).
+        bool is_clipped = !ItemAdd(bb, id);
+        bool hovered, held;
+        bool pressed = ButtonBehavior(bb, id, &hovered, &held, ImGuiButtonFlags_None);
+        if (is_clipped)
+        {
+            ImGui::PopClipRect();
+            return pressed;
+        }
+
+        // const ImU32 bg_col = GetColorU32((held && hovered) ? ImGuiCol_ButtonActive : hovered ? ImGuiCol_ButtonHovered : ImGuiCol_Button);
+        // window->DrawList->AddCircleFilled(bb.GetCenter(), ImMax(2.0f, g.FontSize * 0.5f + 1.0f), bg_col);
+
+        // Draw the label in the center
+        ImU32 text_col = GetColorU32(p_enabled || hovered ? ImGuiCol_Text : ImGuiCol_TextDisabled);
+        window->DrawList->AddText(bb.GetCenter() - ImVec2(g.FontSize * 0.45F, g.FontSize * 0.5F), text_col, label);
+
+        // Return the button press state
+        ImGui::PopClipRect();
+        return pressed;
+    }
+
+    void PopupTitleBarText(const char* text) {
+        ImGuiContext& g = *GImGui;
+        ImGuiWindow* window = g.CurrentWindow;
+        const ImRect title_rect = window->TitleBarRect();
+        const ImVec2 size(g.FontSize, g.FontSize); // Button size matches font size for aesthetic consistency.
+        const ImVec2 pos = window->DC.CursorPos;
+        const ImVec2 max_pos = pos + size;
+        const ImRect bb(pos.x, title_rect.Min.y, max_pos.x, title_rect.Max.y);
+
+        ImGui::PushClipRect(title_rect.Min, title_rect.Max, false);
+
+        // Draw the label in the center
+        ImU32 text_col = GetColorU32(ImGuiCol_Text);
+        window->DrawList->AddText(bb.GetCenter() - ImVec2(g.FontSize * 0.45F, g.FontSize * 0.5F), text_col, text);
+
+        // Return the button press state
+        ImGui::PopClipRect();
+    }
 }
 
 namespace ImGui {

plugins/builtin/include/content/popups/hex_editor/popup_hex_editor_find.hpp

@@ -54,6 +54,8 @@ namespace hex::plugin::builtin {
         TaskHolder m_searchTask;
 
         void processInputString();
+
+        [[nodiscard]] UnlocalizedString getTitle() const override;
     };
 
 } // namespace hex::plugin::builtin

plugins/builtin/include/content/views/view_hex_editor.hpp

@@ -20,6 +20,14 @@ namespace hex::plugin::builtin {
         public:
             virtual ~Popup() = default;
             virtual void draw(ViewHexEditor *editor) = 0;
+
+            [[nodiscard]] virtual UnlocalizedString getTitle() const { return {}; }
+
+            [[nodiscard]] virtual bool canBePinned() const { return false; }
+            [[nodiscard]] bool isPinned() const { return m_isPinned; }
+            void setPinned(const bool pinned) { m_isPinned = pinned; }
+        private:
+            bool m_isPinned = false;
         };
 
         [[nodiscard]] bool isAnyPopupOpen() const {
@@ -71,6 +79,9 @@ namespace hex::plugin::builtin {
         ui::HexEditor m_hexEditor;
 
         bool m_shouldOpenPopup = false;
+        bool m_currentPopupHasHovered = false; // This flag prevents the popup from initially appearing with the transparency effect
+        bool m_currentPopupHover = false;
+        bool m_currentPopupDetached = false;
         std::unique_ptr<Popup> m_currPopup;
 
         PerProvider<std::optional<u64>> m_selectionStart, m_selectionEnd;

plugins/builtin/romfs/themes/classic.json

@@ -333,7 +333,8 @@
             ]
         },
         "imhex": {
-            "window-blur": 0.0
+            "window-blur": 0.0,
+            "popup-alpha": 0.65
         }
     }
 }

plugins/builtin/romfs/themes/dark.json

@@ -333,7 +333,8 @@
             ]
         },
         "imhex": {
-            "window-blur": 0.0
+            "window-blur": 0.0,
+            "popup-alpha": 0.65
         }
     }
 }

plugins/builtin/romfs/themes/light.json

@@ -333,7 +333,8 @@
             ]
         },
         "imhex": {
-            "window-blur": 0.0
+            "window-blur": 0.0,
+            "popup-alpha": 0.65
         }
     }
 }

plugins/builtin/source/content/popups/hex_editor/popup_hex_editor_find.cpp

@@ -29,8 +29,6 @@ namespace hex::plugin::builtin {
     }
 
     void PopupFind::draw(ViewHexEditor *editor) {
-        ImGui::TextUnformatted("hex.builtin.view.hex_editor.menu.file.search"_lang);
-
         auto lastMode = *s_searchMode;
         if (ImGui::BeginTabBar("##find_tabs")) {
             if (ImGui::BeginTabItem("hex.builtin.view.hex_editor.search.hex"_lang)) {
@@ -302,4 +300,8 @@ namespace hex::plugin::builtin {
                 break;
         }
     }
+
+    [[nodiscard]] UnlocalizedString PopupFind::getTitle() const {
+        return "hex.builtin.view.hex_editor.menu.file.search";
+    }
 }

plugins/builtin/source/content/themes.cpp

@@ -354,6 +354,7 @@ namespace hex::plugin::builtin {
                 auto &style = ImGuiExt::GetCustomStyle();
                 const static ThemeManager::StyleMap ImHexStyleMap = {
                         { "window-blur",    { &style.WindowBlur,    0.0F,   1.0F,   true } },
+                        { "popup-alpha",            { &style.PopupWindowAlpha,          0.0F,   1.0F,    false } },
                 };
 
                 ThemeManager::addStyleHandler("imhex", ImHexStyleMap);