-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all tool Popups to floating windows #1658
Commits on May 8, 2024
-
Refactored tool popup code to use floating windows instead of fixed p…
…opups Additional changes: - Added a 'Pin' button to the floating popup's toolbar. When a tool is pinned, the popup will not close automatically after the action is executed. - Added a virtual function to the `ViewHexEditor::Popup` class, allowing implementations to specify a tool window title.
Configuration menu - View commit details
-
Copy full SHA for badc2bd - Browse repository at this point
Copy the full SHA badc2bdView commit details -
Fixed scaling issues with the new floating tool window UI
Before this change, the modifications to the tool popup UIs did not respect the user's scaling factor settings.
Configuration menu - View commit details
-
Copy full SHA for 356c175 - Browse repository at this point
Copy the full SHA 356c175View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a46960 - Browse repository at this point
Copy the full SHA 6a46960View commit details -
Set the correct popup title localization key in Select popup title, a…
…dd missing EndPopup
Configuration menu - View commit details
-
Copy full SHA for 56cf190 - Browse repository at this point
Copy the full SHA 56cf190View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86bacdb - Browse repository at this point
Copy the full SHA 86bacdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 483a98c - Browse repository at this point
Copy the full SHA 483a98cView commit details -
changed getTitle() to return UnlocalizedString, moved localization co…
…de to ViewHexEditor::drawPopup()
Configuration menu - View commit details
-
Copy full SHA for 1086991 - Browse repository at this point
Copy the full SHA 1086991View commit details -
Fixed the background not being rendered correctly on the transparent …
…window when the user isn't hovering over it In the previous approach, I was using ImGuiWindowFlags_NoBackground combined with an explicitly drawn background rectangle to correctly set the window transparency within ImGuiExt::Begin/EndHoveringPopup(). However with this approach, there was a small but noticeable gap between the window's external borders and the background rectangle, due to the configured default padding. With this new approach, the decision to apply the transparency will always be delayed by one frame, but theis way the whole window can be set to being transparent before ImGuiExt::BeginHoveringPopup().
Configuration menu - View commit details
-
Copy full SHA for b6a5037 - Browse repository at this point
Copy the full SHA b6a5037View commit details -
Added support for customizable transparency for Popup windows when th…
…e user isn't hovering over
Configuration menu - View commit details
-
Copy full SHA for 92ad4f4 - Browse repository at this point
Copy the full SHA 92ad4f4View commit details -
Prevents the popup from initially appearing with the transparency eff…
…ect until the user hovers over it
Configuration menu - View commit details
-
Copy full SHA for e9cf4ef - Browse repository at this point
Copy the full SHA e9cf4efView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3ffd2a - Browse repository at this point
Copy the full SHA e3ffd2aView commit details -
Fixed issue that made Popups disappear completely with a misconfigure…
…d PopupWindowAlpha value
Configuration menu - View commit details
-
Copy full SHA for 919590c - Browse repository at this point
Copy the full SHA 919590cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc0dd93 - Browse repository at this point
Copy the full SHA dc0dd93View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc12859 - Browse repository at this point
Copy the full SHA cc12859View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bfb402 - Browse repository at this point
Copy the full SHA 0bfb402View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d7f0ad - Browse repository at this point
Copy the full SHA 1d7f0adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62b585f - Browse repository at this point
Copy the full SHA 62b585fView commit details -
Replaced redundant
justOpened
flag withImGui::IsWindowAppearing()
This fix restores the previously decided behavior ensuring that newly opened popup windows are initially non-transparent, until the user hovers over them for the first time.
Configuration menu - View commit details
-
Copy full SHA for 07f7fe9 - Browse repository at this point
Copy the full SHA 07f7fe9View commit details
Commits on May 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fb9c65b - Browse repository at this point
Copy the full SHA fb9c65bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b014fa - Browse repository at this point
Copy the full SHA 3b014faView commit details -
Fixed bug that was causing popup windows outside the root window to d…
…isappear on click This if branch handles the case when the user clicks outside of the currently visible popup, and it loses focus. But if the popup loses focus while `ImGui::IsWindowHovered()` still returns true, it means that the focus loss was not caused by the user clicking away, so it should not be closed yet. Since the focus loss was only registered when clicking on the background / title bar of the popup, and not any of its child widgets, this could be an ImGui bug.
Configuration menu - View commit details
-
Copy full SHA for 72701a6 - Browse repository at this point
Copy the full SHA 72701a6View commit details -
Updated scaling calculations to use the _scaled UDL instead of manual…
…ly multiplying with the scale factor
Configuration menu - View commit details
-
Copy full SHA for 02dc312 - Browse repository at this point
Copy the full SHA 02dc312View commit details
Commits on May 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c555195 - Browse repository at this point
Copy the full SHA c555195View commit details