Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👥 No duplicate authors #198

Merged
merged 2 commits into from
Aug 29, 2024
Merged

👥 No duplicate authors #198

merged 2 commits into from
Aug 29, 2024

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Aug 28, 2024

Authors

  • Updates AuthorsOrderable to disallow duplicate authors
    • Using THIS ONE unique_together TRICK!!!
  • Updates model to require author field of Orderable

Closes #194

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (0efceae) to head (858d925).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   89.46%   89.64%   +0.17%     
==========================================
  Files          61       63       +2     
  Lines         712      724      +12     
==========================================
+ Hits          637      649      +12     
  Misses         75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrharpo mrharpo self-assigned this Aug 28, 2024
@mrharpo mrharpo added the enhancement ➕ New feature or request label Aug 28, 2024
@mrharpo mrharpo added this to the 🛰 Open Vault Launch milestone Aug 28, 2024
@mrharpo mrharpo merged commit b700cfe into main Aug 29, 2024
10 checks passed
@mrharpo mrharpo deleted the 194-duplicate-authors branch August 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Should not be able to attach the same author 2+ times to an exhibit
1 participant