add relevance check to avoid creating additional entity #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollend
added a commit
to Terasology/SimpleFarming
that referenced
this pull request
Oct 5, 2020
- clean up code - fix test cases PR: Terasology/ModuleTestingEnvironment#27
skaldarnar
approved these changes
Oct 15, 2020
Comment on lines
+252
to
+254
| if (worldProvider.isBlockRelevant(blockPos)) { | ||
| return; | ||
| } |
| import java.util.List; | ||
|
|
||
| @RegisterWorldGenerator(id = "empty", displayName = "empty") | ||
| public class EmptyWorldGenerator extends BaseFacetedWorldGenerator { |
There was a problem hiding this comment.
What is this supposed to be used for? Could we add a little bit of JavaDoc explaining the intended use case?
|
I can reproduce the failing tests locally, although it needed two runs for both to show up 🙄
As the associated error messages state that the actual state was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some slight optimization for dummy entity for loading chunks. creating these RelevanceRegion Entities seems to be add a usability problem to writing test cases.