feat(JOML): migrate SimpleFarming #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clean up code - fix test cases PR: Terasology/ModuleTestingEnvironment#27
pollend
added a commit
to Terasology/AdditionalRails
that referenced
this pull request
Oct 5, 2020
pollend
added a commit
to Terasology/MetalRenegades
that referenced
this pull request
Oct 5, 2020
skaldarnar
reviewed
Oct 15, 2020
src/test/java/org/terasology/simpleFarming/systems/PlantAuthoritySystemTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/terasology/simpleFarming/systems/PlantAuthoritySystemTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/terasology/simpleFarming/systems/PlantAuthoritySystemTest.java
Outdated
Show resolved
Hide resolved
| Assertions.assertTrue(dropSpy.getEntityRefs().stream().anyMatch(k -> k.getParentPrefab().getName().equals(component.produce))); | ||
|
|
||
| // check if bush is at max growth state | ||
| assertEquals(component.growthStages.size() - 2, component.currentStage); |
There was a problem hiding this comment.
So, the max growth stage is one state before the final growth state? This is confusing 🙄
Comment on lines
+297
to
+298
| Block belowBlock = worldProvider.getBlock(position.add(0,-1,0)); | ||
| position.add(0,1,0); |
There was a problem hiding this comment.
I can already see how error prone this is 🙈
src/main/java/org/terasology/simpleFarming/systems/PlantAuthoritySystem.java
Outdated
Show resolved
Hide resolved
| @@ -298,11 +288,11 @@ public void onPlantDestroyed(DoDestroyPlant event, EntityRef entity, BushDefinit | |||
| * | |||
| * @param bushComponent the bush component of the entity | |||
| */ | |||
| private void onBushDestroyed(Vector3i position, EntityRef bush, BushDefinitionComponent bushComponent) { | |||
| private void onBushDestroyed(Vector3ic position, EntityRef bush, BushDefinitionComponent bushComponent) { | |||
…itySystem.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
…itySystemTest.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
…itySystemTest.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
…itySystemTest.java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
jdrueckert
approved these changes
Nov 5, 2020
jdrueckert
pushed a commit
to Terasology/AdditionalRails
that referenced
this pull request
Nov 5, 2020
jdrueckert
pushed a commit
to Terasology/MetalRenegades
that referenced
this pull request
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: add relevance check to avoid creating additional entity ModuleTestingEnvironment#27