-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add relevance check to avoid creating additional entity #27
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7b3c9b5
add relevance check to avoid creating additional entity
pollend 9218003
use relevance check and add empty world
pollend 5a04ecf
update docs
pollend fa6359f
split `testExample` into smaller tests
skaldarnar 2c7c2a9
update license header
skaldarnar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
src/main/java/org/terasology/moduletestingenvironment/fixtures/EmptyWorldGenerator.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
// Copyright 2020 The Terasology Foundation | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package org.terasology.moduletestingenvironment.fixtures; | ||
|
||
import org.terasology.engine.SimpleUri; | ||
import org.terasology.registry.In; | ||
import org.terasology.world.generation.BaseFacetedWorldGenerator; | ||
import org.terasology.world.generation.WorldBuilder; | ||
import org.terasology.world.generator.RegisterWorldGenerator; | ||
import org.terasology.world.generator.plugin.WorldGeneratorPlugin; | ||
import org.terasology.world.generator.plugin.WorldGeneratorPluginLibrary; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
/** | ||
* Bare World Generator to generating empty chunks for testing. | ||
*/ | ||
@RegisterWorldGenerator(id = "empty", displayName = "empty") | ||
public class EmptyWorldGenerator extends BaseFacetedWorldGenerator { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this supposed to be used for? Could we add a little bit of JavaDoc explaining the intended use case? |
||
@In | ||
private WorldGeneratorPluginLibrary worldGeneratorPluginLibrary; | ||
|
||
public EmptyWorldGenerator(SimpleUri uri) { | ||
super(uri); | ||
} | ||
|
||
@Override | ||
protected WorldBuilder createWorld() { | ||
return new WorldBuilder(new WorldGeneratorPluginLibrary() { | ||
@Override | ||
public <U extends WorldGeneratorPlugin> List<U> instantiateAllOfType(Class<U> ofType) { | ||
return new ArrayList<>(); | ||
} | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally makes sense! 👍