feat: making players invulnerable before game round starts #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the NPE when player dies on fool's platform either by getting killed by other player or by falling because this PR adds `InvulnerableComponent` to the player as soon as it gets spawned
jdrueckert
reviewed
Nov 21, 2021
There was a problem hiding this comment.
Please note, that this PR is not actually fixing the NPE. It only results in the side effect that players won't die and, thus, won't run into the NPE situation. This is an important difference.
So please adjust the PR title and description to reflect that this PR is about making players invulnerable before the game actually starts to avoid players killing each other or accidentally dying before the start of an LaS round.
ujjman
changed the title
jdrueckert
changed the title
jdrueckert
added
Category: Gameplay Content
jdrueckert
reviewed
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
InvulnerableComponentto the players before the match to prevent the players from accidentally dying or killing each other before the actual game rounds start