Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when jumping from fool's platform #243

Closed
jdrueckert opened this issue Nov 2, 2021 · 4 comments
Closed

Crash when jumping from fool's platform #243

jdrueckert opened this issue Nov 2, 2021 · 4 comments
Labels
Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Good First Issue Good for learners that are new to Terasology Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems

Comments

@jdrueckert
Copy link
Member

I climbed the side of the fool's platform and jumped off it.
When I hit the ground and died due to fall damage, the game crashed with the following NPE:

java.lang.NullPointerException: null
	at org.joml.Vector3f.add(Vector3f.java:608)
	at org.terasology.ligthandshadow.componentsystem.controllers.PlayerDeathSystem.beforeDestroy(PlayerDeathSystem.java:69)
	at org.terasology.ligthandshadow.componentsystem.controllers.PlayerDeathSystemMethodAccess.invoke(Unknown Source)
	at org.terasology.engine.entitySystem.event.internal.EventSystemImpl$ByteCodeEventHandlerInfo.invoke(EventSystemImpl.java:379)
	at org.terasology.engine.entitySystem.event.internal.EventSystemImpl.sendConsumableEvent(EventSystemImpl.java:254)
	at org.terasology.engine.entitySystem.event.internal.EventSystemImpl.send(EventSystemImpl.java:233)
	at org.terasology.engine.core.bootstrap.eventSystem.AbstractEventSystemDecorator.send(AbstractEventSystemDecorator.java:67)
	at org.terasology.engine.network.NetworkEventSystemDecorator.send(NetworkEventSystemDecorator.java:54)
	at org.terasology.engine.core.bootstrap.eventSystem.AbstractEventSystemDecorator.send(AbstractEventSystemDecorator.java:67)
	at org.terasology.engine.recording.RecordingEventSystemDecorator.send(RecordingEventSystemDecorator.java:34)
	at org.terasology.engine.entitySystem.entity.internal.BaseEntityRef.send(BaseEntityRef.java:190)
	at org.terasology.engine.logic.health.EntityDestructionAuthoritySystem.onDestroy(EntityDestructionAuthoritySystem.java:22)
	at org.terasology.engine.logic.health.EntityDestructionAuthoritySystemMethodAccess.invoke(Unknown Source)
	at org.terasology.engine.entitySystem.event.internal.EventSystemImpl$ByteCodeEventHandlerInfo.invoke(EventSystemImpl.java:379)
	at org.terasology.engine.entitySystem.event.internal.EventSystemImpl.sendStandardEvent(EventSystemImpl.java:244)
	at org.terasology.engine.entitySystem.event.internal.EventSystemImpl.send(EventSystemImpl.java:235)
	at org.terasology.engine.core.bootstrap.eventSystem.AbstractEventSystemDecorator.send(AbstractEventSystemDecorator.java:67)
	at org.terasology.engine.network.NetworkEventSystemDecorator.send(NetworkEventSystemDecorator.java:54)
	at org.terasology.engine.core.bootstrap.eventSystem.AbstractEventSystemDecorator.send(AbstractEventSystemDecorator.java:67)
	at org.terasology.engine.recording.RecordingEventSystemDecorator.send(RecordingEventSystemDecorator.java:34)
	at org.terasology.engine.entitySystem.entity.internal.BaseEntityRef.send(BaseEntityRef.java:190)
	at org.terasology.module.health.systems.DamageAuthoritySystem.doDamage(DamageAuthoritySystem.java:103)
@jdrueckert jdrueckert added Type: Bug Issues reporting and PRs fixing problems Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. labels Nov 2, 2021
@jdrueckert
Copy link
Member Author

@ujjman as you're tracking down NPEs at the moment, maybe this would be something for you 😉

@jdrueckert jdrueckert changed the title Crash on jumping from fool's platform Crash when jumping from fool's platform Nov 2, 2021
@jdrueckert jdrueckert added the Good First Issue Good for learners that are new to Terasology label Nov 2, 2021
@ujjman
Copy link
Member

ujjman commented Nov 3, 2021

Actually I found this bug 3 to 4 days back and discussed it on discord. This error also occurs when the player jumps on the fool's platform using hjump or hspeed . I can fix this pretty easily but what happens when the player dies? Should the player respawn to the fool's platform or just start the game from where it died? If the player respawns on the fool's platform, then we need to useCharacterTeleportEvent , which needs to be fixed for LAS

@jdrueckert
Copy link
Member Author

If the player entity has a component that indicates they already belong to the red or black team, then they should spawn on their team's base. If they don't, they should spawn on the fool's platform, I'd say.

@jdrueckert
Copy link
Member Author

Mitigated by #250 and underlying issue fixed by #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Crash Requests, Issues and Changes targeting unexpected terminations, segfaults, etc. Good First Issue Good for learners that are new to Terasology Status: Needs Investigation Requires to be checked for feasibility, reproducability, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdrueckert @ujjman