[API] Include ImPlot #56

calvertdw · 2021-05-13T21:20:29Z

I might need some help. When I run ./gradlew :imgui-binding:generateLibs -Denvs=linux64 -Dlocal I don't see any generated Java. Am I missing something? I tried to copy from what @AAstroPhysiCS was doing with Imguizmo.

Do I have to write the Java classes by hand? 😅
No problem if so.

calvertdw · 2021-05-13T22:38:40Z

Hm. I tried to add only the method that shows the demo window, unfortunately it gives an error when I enable the checkbox.

Exception in thread "main" java.lang.UnsatisfiedLinkError: imgui.extension.implot.ImPlot.nShowDemoWindow([Z)V
        at imgui.extension.implot.ImPlot.nShowDemoWindow(Native Method)
        at imgui.extension.implot.ImPlot.showDemoWindow(ImPlot.java:16)
        at ExampleImPlot.show(ExampleImPlot.java:29)
        at Extra.show(Extra.java:39)
        at Main.process(Main.java:85)
        at imgui.app.Window.run(Window.java:146)
        at imgui.app.Application.launch(Application.java:83)
        at Main.main(Main.java:97)

Any ideas? Maybe I have to implement the whole thing to get one method to work?

SpaiR · 2021-05-14T05:48:36Z

I don't see any generated Java.

Generator creates JNI layer, so it could be defined much easier. But everything else should be created manually. See PR with ImGuizmo, classes has a code where they are calling native API.

calvertdw · 2021-05-14T15:56:49Z

😭 I already referenced ImGuizmo. As far as I can tell, I'm doing it as closely the same as possible, however ImNodes and ImGuizmo have some differences to ImPlot. Not sure what to try.

calvertdw · 2021-05-14T16:02:29Z

The ImNodes editor works but I get the UnsatisfiedLinkException when I try to show the ImPlot demo.

calvertdw · 2021-05-14T16:05:39Z

It is generating the JNI files:

package imgui.extension.implot;

import imgui.type.ImBoolean;

public final class ImPlot {
    private ImPlot() {

    }

    /*JNI
        #include "_common.h"
        #include "implot.h"

     */

    public static void showDemoWindow(ImBoolean pOpen) {
        nShowDemoWindow(pOpen.getData());
    }

    private static native void nShowDemoWindow(boolean[] pOpen); /*
        ImPlot::ShowDemoWindow(&pOpen[0]);
    */
}

/* DO NOT EDIT THIS FILE - it is machine generated */
#include <jni.h>
/* Header for class imgui_extension_implot_ImPlot */

#ifndef _Included_imgui_extension_implot_ImPlot
#define _Included_imgui_extension_implot_ImPlot
#ifdef __cplusplus
extern "C" {
#endif
/*
 * Class:     imgui_extension_implot_ImPlot
 * Method:    nShowDemoWindow
 * Signature: ([Z)V
 */
JNIEXPORT void JNICALL Java_imgui_extension_implot_ImPlot_nShowDemoWindow
  (JNIEnv *, jclass, jbooleanArray);

#ifdef __cplusplus
}
#endif
#endif

#include <imgui_extension_implot_ImPlot.h>

//@line:10

        #include "_common.h"
        #include "implot.h"

     JNIEXPORT void JNICALL Java_imgui_extension_implot_ImPlot_nShowDemoWindow(JNIEnv* env, jclass clazz, jbooleanArray obj_pOpen) {
	bool* pOpen = (bool*)env->GetPrimitiveArrayCritical(obj_pOpen, 0);


//@line:20

        ImPlot::ShowDemoWindow(&pOpen[0]);
    
	env->ReleasePrimitiveArrayCritical(obj_pOpen, pOpen, 0);

}

AAstroPhysiCS · 2021-05-14T16:15:20Z

Either you are not correctly building the dll files or you are not using the newest dll file.
After you've built the native libraries, you should get a new dll file and you should be using that one.

The UnsatisfiedLinkError is thrown when an application attempts to load a native library like .so in Linux, .dll on Windows or .dylib in Mac and that library does not exist.

calvertdw · 2021-05-14T16:26:47Z

Ohhh! It works now. I didn't perform the step of copying from imgui-binding/build/libsNative/linux64/libimgui-java64.so -> bin/libimgui-java64.so.

2021-05-14.11-23-54.mp4

SpaiR · 2021-05-15T13:56:36Z

@calvertdw Can you please mark your PR as a WIP in the title? So I will understand when it will be good to review.

(except for PlotImage, which is not currently supported)

calvertdw · 2021-06-18T18:12:36Z

@SpaiR @perrymacmurray has helped me put together the rest of this PR. It is ready for your review. Thanks!

SpaiR

Also, please remove bin/libimgui-java64.so file from the list of modified stuff.

With minor adjustments changes look very decent and clean. Great job!

SpaiR · 2021-06-19T09:48:31Z

example/src/main/java/ExampleImPlot.java

+import java.net.URI;
+
+public class ExampleImPlot {
+    private static final String URL = "https://github.com/epezent/implot";


Make the url to point to the concrete commit, instead of repo in general. As for other examples.

SpaiR · 2021-06-19T09:51:22Z

example/src/main/java/ExampleImPlot.java

+            ImGui.checkbox("Show ImPlot Built-In Demo", showDemo);
+
+            final Integer[] xs = {0, 1, 2, 3, 4, 5};
+            final Integer[] ys = {0, 1, 2, 3, 4, 5};


It's better to move those axes to the class fields.

SpaiR · 2021-06-19T09:54:09Z

example/src/main/java/ExampleImPlot.java

+        ImGui.setNextWindowSize(500, 400, ImGuiCond.Once);
+        ImGui.setNextWindowPos(ImGui.getMainViewport().getPosX() + 100, ImGui.getMainViewport().getPosY() + 100, ImGuiCond.Once);
+        if (ImGui.begin("ImPlot Demo", showImPlotWindow))
+        {


Use java style braces.

SpaiR · 2021-06-19T09:54:45Z

example/src/main/java/ExampleImPlot.java

+
+            if (ImPlot.beginPlot("Example Plot")) {
+
+            ImPlot.plotLine("Line", xs, ys);


Broken indentation.

SpaiR · 2021-06-19T09:56:43Z

example/src/main/java/Main.java

@@ -32,6 +36,11 @@ protected void initImGui(final Configuration config) {
        io.addConfigFlags(ImGuiConfigFlags.ViewportsEnable);    // Enable Multi-Viewport / Platform Windows
        io.setConfigViewportsNoTaskBarIcon(true);

+        ImNodes.createContext();


Here and below, you've fixed merge conflicts imporperly. See how this method looks in master.

SpaiR · 2021-06-19T09:58:08Z

imgui-binding/src/main/java/imgui/extension/implot/ImPlot.java

+        IMPLOT_POINT = new ImPlotPoint(0);
+        IMPLOT_LIMITS = new ImPlotLimits(0);
+        IMPLOT_STYLE = new ImPlotStyle(0);
+    }


You can create objects directly, without creating separate static block.

SpaiR · 2021-06-20T07:13:48Z

imgui-binding/src/main/java/imgui/extension/implot/ImPlotLimits.java

+    }
+
+    private static native long nMin(long ptr); /*
+        ImPlotPoint* p = new ImPlotPoint(((ImPlotLimits*)ptr)->Min());


It seems like in all places with calling new you'll create a memory leak, since in C++ we need to deallocate the heap memory.

SpaiR · 2021-06-20T07:14:53Z

imgui-binding/src/main/java/imgui/extension/implot/ImPlotLimits.java

+    }
+
+    private static native boolean nContains(long ptr, double x, double y); /*
+        return ((ImPlotLimits*)ptr)->Contains(x, y);


((ImPlotLimits*)ptr)

Instead of this construction you can use define like here: https://github.com/SpaiR/imgui-java/blob/master/imgui-binding/src/main/java/imgui/ImFont.java#L23 It's a common way I use everywhere.

I won't go through all places, but it's a common problem of the PR.

Changed ImPlotLimits, ImPlotRange, and ImPlotPoint to extend ImGuiStructDestroyable instead of ImGuiStruct so user-created instances can be destroyed. Methods that create instances that must be destroyed manually specify this in the docs.

perrymacmurray · 2021-06-20T21:43:47Z

@SpaiR I went ahead and fixed the problems you pointed out. I addressed the memory leaks by making the returned instances of the affected classes (ImPlotLimits, ImPlotRange, and ImPlotPoint) extend ImGuiStructDestroyable - this preserves allowing modifying passed data for ImPlot functions that return a Limit or Point pointer (such as for modifying a Range inside a Limit). I also added ImVec2 versions of some getters for when a user might want to simply get data and not worry about manual deallocation.

If there's another way of handling memory that you would prefer so users don't have to worry about calling destroy(), I can change how I implemented the classes, but this method was the best way I could think of.

SpaiR

LGTM 👍

calvertdw added 6 commits May 13, 2021 15:59

Add implot submodule.

a5de8cf

Add implot to generateLibs

0c7c01f

Add _implot.h

8d69a03

Add placeholder ImPlot java classes.

42900c3

Create demo window.

5a6bd1b

Try to show the ImPlot demo in the window.

128e3cf

Create ImPlot context.

4c6d543

calvertdw changed the title ~~Include Implot~~ [API] Include ImPlot May 15, 2021

SpaiR added 3rd party Everything out of the Dear ImGui scope enhancement New feature or request labels May 15, 2021

calvertdw changed the title ~~[API] Include ImPlot~~ [API] [WIP] Include ImPlot May 15, 2021

calvertdw added 4 commits May 15, 2021 15:18

Fix final check.

33b21b2

Implement ImPlotFlags.

f9562bb

Implement the rest of the enums.

282065c

Make classes final.

4ff8788

SpaiR force-pushed the master branch 7 times, most recently from de78a7c to cf09a20 Compare May 30, 2021 19:12

perrymacmurray added 11 commits June 17, 2021 12:43

Implement more ImPlot methods (rest of plot items)

36cf35a

(except for PlotImage, which is not currently supported)

Fix ImGui binding problems due to API changes

2b531c4

Adhere to style guidelines.

69c105f

Fix imguizmo submodule

f5d0a61

Fix API

776d830

Implement ImPlotStyle

68fbf25

Implement more ImPlot methods (Plot and Item styling)

8a9944f

Implement remainder of ImPlot methods (Colormaps)

1eb6382

Modify ImPlot example program

5d05753

Fix ImPlot example program bug

72c9ca5

ImPlot bugfixes

0e8ac7c

calvertdw changed the title ~~[API] [WIP] Include ImPlot~~ [API] Include ImPlot Jun 18, 2021

perrymacmurray and others added 3 commits June 18, 2021 13:24

Update ImPlot Demo

e52821c

Revert merge errors.

2049e41

Make the submodules the version on master.

ce9da77

SpaiR requested changes Jun 20, 2021

View reviewed changes

perrymacmurray added 8 commits June 20, 2021 13:25

Fix URL/style in ExampleImPlot

2da5629

Fix merge conflicts with example ImPlot context creation

db204cf

Remove unneccesary static block for field declarations

f7e4369

Revert libimgui-java64.so

17b4632

Change construction to use define (vs passing a pointer)

15bcc78

Fixed memory leaks

e972b95

Changed ImPlotLimits, ImPlotRange, and ImPlotPoint to extend ImGuiStructDestroyable instead of ImGuiStruct so user-created instances can be destroyed. Methods that create instances that must be destroyed manually specify this in the docs.

Fix style violations

902fb07

Fix compile error

0d0000e

Replace exception type

f40ba6a

SpaiR approved these changes Jun 21, 2021

View reviewed changes

SpaiR merged commit 92fa416 into SpaiR:master Jun 21, 2021

SpaiR mentioned this pull request Jun 21, 2021

Include ImPlot #27

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[API] Include ImPlot #56

[API] Include ImPlot #56

calvertdw commented May 13, 2021

calvertdw commented May 13, 2021

SpaiR commented May 14, 2021

calvertdw commented May 14, 2021

calvertdw commented May 14, 2021 •

edited

Loading

calvertdw commented May 14, 2021 •

edited

Loading

AAstroPhysiCS commented May 14, 2021 •

edited

Loading

calvertdw commented May 14, 2021

SpaiR commented May 15, 2021

calvertdw commented Jun 18, 2021

SpaiR left a comment

SpaiR Jun 19, 2021

SpaiR Jun 19, 2021

SpaiR Jun 19, 2021

SpaiR Jun 19, 2021

SpaiR Jun 19, 2021

SpaiR Jun 19, 2021

SpaiR Jun 20, 2021

SpaiR Jun 20, 2021 •

edited

Loading

perrymacmurray commented Jun 20, 2021

SpaiR left a comment


		if (ImPlot.beginPlot("Example Plot")) {

		ImPlot.plotLine("Line", xs, ys);

[API] Include ImPlot #56

[API] Include ImPlot #56

Conversation

calvertdw commented May 13, 2021

calvertdw commented May 13, 2021

SpaiR commented May 14, 2021

calvertdw commented May 14, 2021

calvertdw commented May 14, 2021 • edited Loading

calvertdw commented May 14, 2021 • edited Loading

AAstroPhysiCS commented May 14, 2021 • edited Loading

calvertdw commented May 14, 2021

SpaiR commented May 15, 2021

calvertdw commented Jun 18, 2021

SpaiR left a comment

Choose a reason for hiding this comment

SpaiR Jun 19, 2021

Choose a reason for hiding this comment

SpaiR Jun 19, 2021

Choose a reason for hiding this comment

SpaiR Jun 19, 2021

Choose a reason for hiding this comment

SpaiR Jun 19, 2021

Choose a reason for hiding this comment

SpaiR Jun 19, 2021

Choose a reason for hiding this comment

SpaiR Jun 19, 2021

Choose a reason for hiding this comment

SpaiR Jun 20, 2021

Choose a reason for hiding this comment

SpaiR Jun 20, 2021 • edited Loading

Choose a reason for hiding this comment

perrymacmurray commented Jun 20, 2021

SpaiR left a comment

Choose a reason for hiding this comment

calvertdw commented May 14, 2021 •

edited

Loading

calvertdw commented May 14, 2021 •

edited

Loading

AAstroPhysiCS commented May 14, 2021 •

edited

Loading

SpaiR Jun 20, 2021 •

edited

Loading