Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to include Youtube channel in Signup #3411

Closed
wants to merge 1 commit into from

Conversation

tcvan0707
Copy link
Contributor

Issue This PR Addresses

Fixes #2676

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR will allow user to include their Youtube channel when registering their account in Telescope.

NOTE: This PR is not fully completed yet. I am still not able to get the feed from Youtube channel, and the Youtube URL does not get the MuiInputLable-shrink. Advices are welcome ^^

Steps to test the PR

  • run pnpm services:start
  • go to localhost:8000
  • click the Sign In button
  • Use the test account to sign in in SAML: username: user1, password: user1pass
  • If successful, your account is created and can be found at http://localhost:8910/project/default/editor under the telescope_profiles table

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2022

@tcvan0707 tcvan0707 self-assigned this Apr 6, 2022
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more complicated than it needs to be. We only need to make it clear that you can specify a YouTube channel as one of your feeds, and the rest should just work (i.e., it's a normal feed URL).

@@ -106,6 +106,7 @@ const createNewProfile = async (id, body) => {
githubUsername,
githubAvatarUrl,
blogUrl,
youtubeUrl,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to modify the schema of a user in the DB. A YouTube channel is just another RSS feed that happens to be hosted on YouTube.

@DukeManh
Copy link
Contributor

DukeManh commented Apr 6, 2022

@tcvan0707, according to your comment, here are my ideas to implement this:

  • Add another page to the signup flow for users' Twitch account, it has 3 pages currently, 1 for the general info, 1 for the blog URL, and 1 for the GitHub account.
  • This page is skippable, unlike the required Blog URL or GitHub account. We are using Formik to validate inputs, to make this page skippable, add a rule in Formik that allows empty value of the twitch channel
  • When users enter the twitch channel name, make a request to our RSS-bridge service to get the feed-URL
  • After the signup flow, you may end up with data like:
  blogs: [
    { URL: '123', type: 'blog'},
    { URL: '456', type: 'twitch'},
  ]
  • Send this data to SSO service which will then handle this data and add insert the twitch feed URL to the database.

@dbelokon dbelokon self-requested a review April 12, 2022 01:20
@tcvan0707 tcvan0707 closed this Apr 12, 2022
@humphd
Copy link
Contributor

humphd commented Apr 12, 2022

@tcvan0707 why did we close this?

@tcvan0707
Copy link
Contributor Author

@tcvan0707 why did we close this?

I am working on changes, so I will close this one and open the new PR, or can we convert this one to the actual PR?

@tcvan0707 tcvan0707 reopened this Apr 12, 2022
@JerryHue JerryHue added this to the 3.0 Release milestone Apr 12, 2022
@TueeNguyen
Copy link
Contributor

@tcvan0707 this is good for review right?

@tcvan0707
Copy link
Contributor Author

@tcvan0707 this is good for review right?

This one will be closed in the future via #3505

@TueeNguyen
Copy link
Contributor

Ok, focus on the other one then

@tcvan0707
Copy link
Contributor Author

Closed via #3505

@tcvan0707 tcvan0707 closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow YouTube channels to be added via the sign-up UI
6 participants