Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow YouTube channels to be added via the sign-up UI #2676

Closed
humphd opened this issue Jan 19, 2022 · 10 comments
Closed

Allow YouTube channels to be added via the sign-up UI #2676

humphd opened this issue Jan 19, 2022 · 10 comments
Assignees
Labels
Milestone

Comments

@humphd
Copy link
Contributor

humphd commented Jan 19, 2022

In #2675 we're adding support for YouTube feed discovery. We need to update the UI to allow a user to include their YouTube channel, along with their blog(s).

@humphd humphd added type: enhancement New feature or request area: front-end labels Jan 19, 2022
@nguyenhung15913
Copy link
Contributor

Hi David, I would like to know this issue in more details. Should we add a new form field for the user to enter the Youtube channel in the Sign Up page? Also at the moment, when I am trying to sign up for Telescope, there is a pop-up but it only has 2 buttons (previous and next)

@nguyenhung15913
Copy link
Contributor

image
here is the screenshot

@humphd
Copy link
Contributor Author

humphd commented Jan 19, 2022

We have a form now for adding your blog URL(s), and we need to update the wording and verification code so it is clear you can include a YouTube channel.

@nguyenhung15913
Copy link
Contributor

I guess the form you are talking about is in src\web\src\components\SignUp\Forms\RSSFeeds.tsx right? My question is how does it look like in the browser or where can I see the form? Because the screenshot above is what I have when I press the Sign Up button.

@humphd
Copy link
Contributor Author

humphd commented Jan 20, 2022

We've got the sign-up stuff turned off at the moment. Talk to @DukeManh, he wrote a lot of it, and can give some ideas.

@DukeManh
Copy link
Contributor

I'll have a PR for fixing this Bug.

@RC-Lee RC-Lee added this to the 2.9 Release milestone Mar 14, 2022
@JerryHue
Copy link
Contributor

JerryHue commented Mar 22, 2022

@nguyenhung15913, what is the progress related to this issue? Have you managed to implement a small PR that can address it? Would you need somebody else's assistance regarding this?

@DukeManh
Copy link
Contributor

DukeManh commented Apr 5, 2022

@nguyenhung15913 , if you can make a draft PR, I can help debug the CSS with you.

@nguyenhung15913
Copy link
Contributor

@nguyenhung15913 , if you can make a draft PR, I can help debug the CSS with you.

For now, I have been working on the loading posts for Mobile app, because we don't have a lot of time and the posts component is huge. If no one is working on this, I can do it

@menghif
Copy link
Contributor

menghif commented Apr 20, 2022

Closed in #3505

@menghif menghif closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants