Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up ESLint for dependency-discovery #3168

Merged
merged 1 commit into from
Mar 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions src/api/dependency-discovery/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
module.exports = {
extends: '@senecacdot/eslint-config-telescope',

overrides: [
{
files: ['./**/*.js'],
env: {
jest: true,
commonjs: true,
es2021: true,
node: true,
},
},
],
};
7 changes: 6 additions & 1 deletion src/api/dependency-discovery/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
"description": "A dependency graph compilation service for Telescope",
"scripts": {
"start": "node src/server.js",
"dev": "env-cmd -f env.local nodemon src/server.js"
"dev": "env-cmd -f env.local nodemon src/server.js",
"lint": "pnpm eslint",
"eslint": "eslint --config .eslintrc.js \"**/*.js\"",
"eslint-fix": "eslint --config .eslintrc.js \"**/*.js\" --fix"
},
"repository": {
"type": "git",
Expand All @@ -22,7 +25,9 @@
"query-registry": "2.2.0"
},
"devDependencies": {
"@senecacdot/eslint-config-telescope": "workspace:1.0.0",
"env-cmd": "10.1.0",
"eslint": "7.32.0",
"nodemon": "2.0.15"
}
}
10 changes: 5 additions & 5 deletions src/api/dependency-discovery/src/dependency-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ async function getDependencyList() {
return Object.keys(dependencies);
}

async function isPackageDependency(packageName) {
const dependencies = await getDependencies();
return Object.prototype.hasOwnProperty.call(dependencies, packageName);
}

async function getNpmPackageInfo(packageName) {
if (!(await isPackageDependency(packageName))) {
return null;
Expand All @@ -46,11 +51,6 @@ async function getNpmPackageInfo(packageName) {
return dependencies[packageName];
}

async function isPackageDependency(packageName) {
const dependencies = await getDependencies();
return Object.prototype.hasOwnProperty.call(dependencies, packageName);
}

module.exports = {
getDependencyList,
getNpmPackageInfo,
Expand Down
3 changes: 2 additions & 1 deletion src/api/dependency-discovery/test/dependency.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ const depsList = [
];

jest.mock('../src/dependency-list');
const { __setMockDepList } = require('../src/dependency-list');

describe('GET /projects', () => {
beforeEach(() => {
require('../src/dependency-list').__setMockDepList(depsList);
__setMockDepList(depsList);
});

test('Should return 200 and an array of dependencies', async () => {
Expand Down