Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up ESLint for dependency-discovery #3168

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

JerryHue
Copy link
Contributor

Issue This PR Addresses

Fixes #3154

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR sets up the eslint configuration for the dependency-discovery service. It also fixes current eslint issues that occurred when running the linter.

Steps to test the PR

  1. Pull my changes
  2. Checkout my branch (git checkout issue-3154)
  3. Ensure you have the proper dependencies installed (pnpm install)
  4. Run pnpm lint.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Mar 10, 2022

@tpmai22 tpmai22 merged commit 036ee2c into Seneca-CDOT:master Mar 11, 2022
@cindyorangis cindyorangis added this to the 2.8 Release milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure ESLint for dependency-discovery
4 participants