2nd draft of workflow #2775
2nd draft of workflow #2775
Conversation
TDDR
added
type: enhancement
|
|
manekenpix
changed the title
|
|
||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Can you try to change this to the name of the branch you're using and check if this works on your fork?
|
Not really sure why these two commits are trying to be added again. I thought the rebase went fine but the log shows that the new commits got put on top of mine still |
| id: docker_build | ||
| uses: docker/build-push-action@v2 | ||
| with: | ||
| context: src\api\feed-discovery |
There was a problem hiding this comment.
Prefer Unix style paths src/api/feed-discovery
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Build and push | ||
| id: docker_build |
There was a problem hiding this comment.
I don't think we need an id
| jobs: | ||
| docker: | ||
| runs-on: ubuntu-latest | ||
| steps: |
There was a problem hiding this comment.
Let's also include buildx, which gives us some benefits when building multi-stage builds:
name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
See https://docs.docker.com/buildx/working-with-buildx/ for more info.
| context: src\api\feed-discovery | ||
| dockerfile: Dockerfile | ||
| push: true | ||
| tags: user/app:latest |
There was a problem hiding this comment.
Let's tag this slightly different, so we update the latest tag for feed-discovery to this new image:
tags: feed-discovery:latest
I also wonder if we should use feed-discovery:${{github.sha}} later on. But we can add that if we need to go back in time to get old versions.
| @@ -0,0 +1,26 @@ | |||
| name: build-and-push-feed-discovery | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
We could probably add a path section in here to isolate this to changes in src/api/feed-discovery only. cc @menghif, who just did this for our docs workflows.
Issue This PR Addresses
Part Of: #1743
Type of Change
Description
This is an attempt to add a workflow that will build and push our microservice image to the GitHub Container Registry. I am unsure of a couple of lines that I will make a comment on.
I also do not know how I would test locally. Would I not have to test it right in staging in order for the workflow to trigger?