Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate Docker build of Feed-Discovery service with GitHub Actions #1743

Closed
humphd opened this issue Feb 14, 2021 · 9 comments · Fixed by #2784
Closed

Automate Docker build of Feed-Discovery service with GitHub Actions #1743

humphd opened this issue Feb 14, 2021 · 9 comments · Fixed by #2784
Assignees
Labels
area: docker type: enhancement New feature or request
Milestone

Comments

@humphd
Copy link
Contributor

humphd commented Feb 14, 2021

We're moving toward containerizing everything, and it might be time to consider using an automated container build setup with Actions so we can build and push to a registry, then automate our deployments to pull for zero-downtime updates.

GitHub has a new Docker registry, but it looks like the current Seneca-CDOT account doesn't support it? @ctyler do you know anything about CDOT's GitHub org being a "legacy" account?

Screen Shot 2021-02-14 at 3 08 21 PM

I'm not sure if this is fixable or not, but it would be cool to use GitHub's storage for this. I don't think there's another registry that will let us host all these containers for free?

@humphd humphd added type: enhancement New feature or request area: docker labels Feb 14, 2021
@birtony birtony self-assigned this Feb 20, 2021
@birtony
Copy link
Contributor

birtony commented Feb 20, 2021

I'd be keen to look into this

@humphd
Copy link
Contributor Author

humphd commented Jan 19, 2022

@humphd
Copy link
Contributor Author

humphd commented Jan 19, 2022

See #2683

@TDDR TDDR self-assigned this Jan 20, 2022
@AmasiaNalbandian AmasiaNalbandian added this to the 2.6 Release milestone Jan 25, 2022
@humphd humphd changed the title Automate Docker builds with Actions Automate Docker build of Feed-Discovery service with GitHub Actions Jan 25, 2022
@humphd
Copy link
Contributor Author

humphd commented Jan 25, 2022

I updated this to be about getting the feed-discovery service built and the image uploaded to the GitHub Package Registry. Once we figure this out for feed-discovery, we can move onto the others.

@humphd humphd reopened this Jan 31, 2022
@humphd
Copy link
Contributor Author

humphd commented Jan 31, 2022

@TDDR has done great work getting us to the point of being able to do this. However, I've discovered that the CDOT org isn't allowed to publish to the GitHub Package Registry

As I see it, our options are:

  1. move Telescope to its own GitHub org that is totally open (no private repos). This is going to cause a bit of churn while we get all kinds of things set up again with automation, permissions, connected services, etc.
  2. host our own Docker registry on staging/production

I don't think there is another (free) option. Docker Hub is not going to work for a Team, and Amazon ECR will cost.

What do people want to do? I think we have to move toward hosting our images. cc @manekenpix.

@sirinoks
Copy link
Contributor

sirinoks commented Feb 2, 2022

I'm moving the second part of this issue for 2.7. Looks like there are some decisions to be made.

@sirinoks sirinoks modified the milestones: 2.6 Release, 2.7 Release Feb 2, 2022
@humphd
Copy link
Contributor Author

humphd commented Feb 2, 2022

I'll file a follow-up on what remains vs. holding this, since @TDDR's part is actually done and merged.

@humphd
Copy link
Contributor Author

humphd commented Feb 2, 2022

Filed #2801.

@humphd humphd closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docker type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants