Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Issue 1500 - Port SearchInput to NEXT.js #1580

Merged
merged 4 commits into from
Jan 22, 2021
Merged

[next] Issue 1500 - Port SearchInput to NEXT.js #1580

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fedc8f
Create SearchInput.tsx
PedroFonsecaDEV Jan 21, 2021
20ece18
Imports done
PedroFonsecaDEV Jan 21, 2021
9a89455
type created
PedroFonsecaDEV Jan 21, 2021
3e95301
SearchInput - done
PedroFonsecaDEV Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/frontend/next/src/components/SearchInput/SearchInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import PostSearchInput from './PostSearchInput';
import AuthorSearchInput from './AuthorSearchInput';

type searchInputProps = {
text: string;
onTextChange: Function;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here as in #1581 , should we be more specific about the type here? Maybe EventHandler instead of Function

Copy link
Contributor

@HyperTHD HyperTHD Jan 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an onChange event so ChangeEvent is the type here, same as in #1581
Fix that, and this LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it in a follow-up PR, because we are drilling a lot of stuff here. After getting everything working we will need to create an interface to SearchPage's components and a context. These functions are connected to how we build the URL query of a search. So I believe that we need to be care full with that. It's working now. Let's keep this for now.

I'm opening an issue for the next step (interface and context) now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1584

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

searchFilter: string;
};

const SearchInput = ({ text, onTextChange, searchFilter }: searchInputProps) => {
return searchFilter === 'author' ? (
<AuthorSearchInput text={text} onChange={(event) => onTextChange(event.target.value)} />
) : (
<PostSearchInput text={text} onChange={(event) => onTextChange(event.target.value)} />
);
};

export default SearchInput;