Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Create a context to Search components. #1584

Closed
PedroFonsecaDEV opened this issue Jan 22, 2021 · 1 comment · Fixed by #2046
Closed

[next] Create a context to Search components. #1584

PedroFonsecaDEV opened this issue Jan 22, 2021 · 1 comment · Fixed by #2046
Assignees
@HyperTHD
Labels
area: front-end type: enhancement New feature or request

Comments

@PedroFonsecaDEV
Copy link
Contributor

What would you like to be added:
We are drilling props on our SeachPage components, let's create a context to solve this.
Why would you like this to be added:
I don't like to drill more than one level.
This was referenced Jan 22, 2021
Merged
Merged
@manekenpix manekenpix changed the title Create a context to Search components. [next] Create a context to Search components. Jan 22, 2021
@HyperTHD
Copy link
Contributor

I'm gonna fix this once we land #1741 and #1745. Depending on how quick we get those PRs merged, I should be able to land this in either 1.7 or 1.8. Regardless, it's a non-blocking issue

@HyperTHD HyperTHD self-assigned this Feb 16, 2021
@HyperTHD HyperTHD mentioned this issue Mar 30, 2021
Merged
8 tasks
HyperTHD added a commit that referenced this issue Mar 31, 2021
@HyperTHD
Fixes #1584: Create a SearchContext to pass props more easily to Sear…
b831cbd 
…ch Components (#2046)

* Created initial SearchContext

* Moved Search Provider to Search Page
PedroFonsecaDEV added a commit to PedroFonsecaDEV/telescope that referenced this issue Apr 1, 2021
@PedroFonsecaDEV
Revert "Fixes Seneca-CDOT#1584: Create a SearchContext to pass props …
dd5fa09 
…more easily to Search Components (Seneca-CDOT#2046)"

This reverts commit b831cbd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HyperTHD HyperTHD

Labels
area: front-end type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1584: Create a SearchContext to pass props more easily to Search Components
2 participants
@HyperTHD @PedroFonsecaDEV