Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cftime.utime #59

Closed
wants to merge 3 commits into from
Closed

Conversation

aulemahal
Copy link
Contributor

@aulemahal aulemahal commented May 25, 2021

This PR removes all deprecated calls of cftime.utime and uses the "new" way.
Made some pep8 fixes because the pep8 cli was asking for them.

There are 2 1 errors left. They are unrelated to this PR, but seem to come from changes in cftime too. I will dig a bit more.

EDIT: Fixed the error relating to 360_day calendar. Many calls to cftime.datetime were missing the calendar, I added it as this was the issue at least for that error. Also followed to instruction of a DeprecationWarning and changed np.object to object.

@trexfeathers trexfeathers linked an issue Jun 8, 2021 that may be closed by this pull request
27 tasks
@trexfeathers trexfeathers removed a link to an issue Jun 8, 2021
27 tasks
@trexfeathers trexfeathers linked an issue Jun 8, 2021 that may be closed by this pull request
@bjlittle bjlittle added this to the v1.3.0 milestone Jun 8, 2021
@bjlittle bjlittle self-assigned this Jun 9, 2021
@bjlittle
Copy link
Member

Closed by #66

@bjlittle bjlittle closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New cftime 1.5.0 breaks nc-time-axis
3 participants