Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failing cftime plot tests #5344

Closed
keewis opened this issue May 19, 2021 · 2 comments · Fixed by #5461
Closed

failing cftime plot tests #5344

keewis opened this issue May 19, 2021 · 2 comments · Fixed by #5461
Labels
topic-plotting upstream issue

Comments

@keewis
Copy link
Collaborator

keewis commented May 19, 2021

This was reported in #5077 and seems to be an upstream issue (see #5077 (comment)):

FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_line_plot
FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_pcolormesh_plot
FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_contour_plot

In order to get the upsteam-dev CI open new issues for other failing tests on upstream-dev I've xfail'ed them in #5343. This should be undone once it is fixed in either cftime or nc-time-axis.
@spencerkclark
Copy link
Member

Thanks @keewis; I agree it's good to just xfail them for now.

@keewis keewis mentioned this issue May 19, 2021
Closed
@aulemahal
Copy link
Contributor

FYI, I opened SciTools/nc-time-axis#59 to update nc-time-axis. Waiting for maintainers to review.

@spencerkclark spencerkclark mentioned this issue Jun 11, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-plotting upstream issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove xfail decorator from tests that depend on nc-time-axis spencerkclark/xarray
3 participants
@spencerkclark @keewis @aulemahal